From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755018AbYISTnS (ORCPT ); Fri, 19 Sep 2008 15:43:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751536AbYISTnH (ORCPT ); Fri, 19 Sep 2008 15:43:07 -0400 Received: from outbound-sin.frontbridge.com ([207.46.51.80]:8063 "EHLO SG2EHSOBE001.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbYISTnG (ORCPT ); Fri, 19 Sep 2008 15:43:06 -0400 X-BigFish: VPS-17(z1039oz1432R98dR1805M936fQ873fnzz10d3izzz32i6bh43j62h) X-Spam-TCS-SCL: 1:0 X-WSS-ID: 0K7GK2G-04-21N-01 Date: Fri, 19 Sep 2008 21:42:23 +0200 From: Joerg Roedel To: FUJITA Tomonori CC: mingo@elte.hu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remove fullflush and nofullflush in IOMMU generic option Message-ID: <20080919194223.GA10692@amd.com> References: <20080919172036.GT24392@amd.com> <20080920023424H.fujita.tomonori@lab.ntt.co.jp> <20080919174605.GU24392@amd.com> <20080920033021K.fujita.tomonori@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20080920033021K.fujita.tomonori@lab.ntt.co.jp> User-Agent: mutt-ng/devel-r804 (Linux) X-OriginalArrivalTime: 19 Sep 2008 19:42:23.0165 (UTC) FILETIME=[D61D26D0:01C91A8F] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 20, 2008 at 03:40:32AM +0900, FUJITA Tomonori wrote: > On Fri, 19 Sep 2008 19:46:05 +0200 > Joerg Roedel wrote: > > > On Sat, Sep 20, 2008 at 02:34:15AM +0900, FUJITA Tomonori wrote: > > > > You keep this option for AMD IOMMU too. If you move it to AMD IOMMU code > > > > then you can remove nofullflush there. > > > > > > I'm not sure what you mean. You think that we can't change the > > > exported option, how can we remove nofullflush option? > > > > You can keep it for GART. But as I already wrote its ok to remove it for > > AMD IOMMU. > > My patch doesn't add nofullflush option to AMD IOMMU. So we don't > remove to it. > > If my patch adds it to AMD IOMMU, it's a bug. Ah ok, true. I looked at the wrong portion of the patch. Sorry. Joerg -- | AMD Saxony Limited Liability Company & Co. KG Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany System | Register Court Dresden: HRA 4896 Research | General Partner authorized to represent: Center | AMD Saxony LLC (Wilmington, Delaware, US) | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy