From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752936AbYITE1q (ORCPT ); Sat, 20 Sep 2008 00:27:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750821AbYITE1i (ORCPT ); Sat, 20 Sep 2008 00:27:38 -0400 Received: from casper.infradead.org ([85.118.1.10]:49924 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbYITE1i (ORCPT ); Sat, 20 Sep 2008 00:27:38 -0400 Date: Fri, 19 Sep 2008 21:26:30 -0700 From: Greg KH To: Arjan van de Ven Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] debug: Introduce a dev_WARN() function Message-ID: <20080920042630.GA21501@kroah.com> References: <20080919210733.4e9c58e8@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080919210733.4e9c58e8@infradead.org> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 19, 2008 at 09:07:33PM -0700, Arjan van de Ven wrote: > > From: Arjan van de Ven > Date: Fri, 19 Sep 2008 21:03:06 -0700 > Subject: [PATCH] debug: Introduce a dev_WARN() function > > in the line of dev_printk(), this patch introduces a dev_WARN() macro, > that takes a struct device and then a printk format/args set of arguments. > Unlike dev_printk(), the effect is that of WARN() in that a full warning > message (including filename/line, module list, versions and a backtrace) > is printed in addition to the device name and the arguments. I like the idea, but we already have dev_warn(), so dev_WARN() might be a bit confusing for people. Perhaps just documenting it with a docbook tag would suffice? thanks, greg k-h