From: Arjan van de Ven <arjan@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christian Pellegrin <chripell@gmail.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Christian Pellegrin <chripell@fsfe.org>
Subject: Re: [PATCH] max3100 driver
Date: Sat, 20 Sep 2008 06:56:52 -0700 [thread overview]
Message-ID: <20080920065652.11d76780@infradead.org> (raw)
In-Reply-To: <20080920012454.e40f03cc.akpm@linux-foundation.org>
\> > + int rx_enabled:1; /* if we should rx chars */
> > +
> > + int irq; /* irq assigned to the max3100 */
> > +
> > + int minor; /* minor number */
> > + int crystal:1; /* 1 if 3.6864Mhz crystal 0
> > for 1.8432 */
> > + int loopback:1; /* 1 if we are in loopback
> > mode */
> > + int only_edge_irq:1; /* 1 if we have only edge irqs
> > (like PXA) */
>
> Lots of dittoes.
>
> These bitfields perhaps could be reordered to save a bit of space, but
> that depends on the implicit locking rules for them.
>
I do have a question though: what does a signed bitfield of 1 mean?
I mean.. the variables are "int", so signed.... where will the compiler
store the sign bit???
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2008-09-20 13:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-20 7:20 [PATCH] max3100 driver Christian Pellegrin
2008-09-20 8:24 ` Andrew Morton
2008-09-20 10:35 ` chri
2008-09-20 13:56 ` Arjan van de Ven [this message]
2008-09-20 14:30 ` chri
2008-09-20 14:34 ` Alan Cox
2008-09-21 16:09 ` Ben Pfaff
2008-10-09 6:23 ` chri
2008-10-10 12:08 ` Christian Pellegrin
2008-09-20 14:11 ` Alan Cox
2008-09-20 14:37 ` chri
2008-10-09 6:30 ` chri
2008-10-09 9:18 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2008-09-20 10:51 Michael Trimarchi
2007-12-17 8:17 chripell
2007-12-17 8:45 ` Jiri Slaby
2007-12-17 8:55 ` chri
2007-12-17 9:00 ` Jiri Slaby
2007-12-05 10:26 chripell
2007-12-12 9:49 ` Andrew Morton
2007-12-12 11:58 ` chri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080920065652.11d76780@infradead.org \
--to=arjan@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=chripell@fsfe.org \
--cc=chripell@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox