From: Andrew Morton <akpm@linux-foundation.org>
To: "Dan Williams" <dan.j.williams@intel.com>
Cc: "Timur Tabi" <timur@freescale.com>,
haavard.skinnemoen@atmel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmatest: properly handle duplicate DMA channels
Date: Sat, 20 Sep 2008 15:20:48 -0700 [thread overview]
Message-ID: <20080920152048.75ea4655.akpm@linux-foundation.org> (raw)
In-Reply-To: <e9c3a7c20809201440t739ea58enede8d0d6a70f5118@mail.gmail.com>
On Sat, 20 Sep 2008 14:40:40 -0700 "Dan Williams" <dan.j.williams@intel.com> wrote:
> When I fix this up is there a
> canonical location to document a callback interface rather than at the
> callback's typedef?
Personally I like to see at at the definition site, so that's within
the struct which contains the function pointer. eg:
struct address_space_operations {
int (*writepage)(struct page *page, struct writeback_control *wbc);
int (*readpage)(struct file *, struct page *);
void (*sync_page)(struct page *);
/* Write back some dirty pages from this mapping. */
int (*writepages)(struct address_space *, struct writeback_control *);
/* Set a page dirty. Return true if this dirtied it */
int (*set_page_dirty)(struct page *page);
(sadly incomplete, but we tried)
prev parent reply other threads:[~2008-09-20 22:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 15:21 [PATCH] dmatest: properly handle duplicate DMA channels Timur Tabi
2008-09-18 15:32 ` Haavard Skinnemoen
2008-09-18 15:34 ` Timur Tabi
2008-09-18 15:48 ` Haavard Skinnemoen
2008-09-19 23:31 ` Andrew Morton
2008-09-20 12:42 ` Haavard Skinnemoen
2008-09-20 21:40 ` Dan Williams
2008-09-20 22:20 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080920152048.75ea4655.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox