From: Paul Mundt <lethal@linux-sh.org>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Mathieu Desnoyers <compudj@krystal.dyndns.org>,
"Frank Ch. Eigler" <fche@redhat.com>,
Roland McGrath <roland@redhat.com>
Subject: [PATCH] [RFC] tracehook: Hook in syscall tracing markers.
Date: Sun, 21 Sep 2008 11:16:30 +0900 [thread overview]
Message-ID: <20080921021630.GA6443@linux-sh.org> (raw)
At kernel summit, the idea that syscall tracing was generally desirable
for tracing was mentioned several times, as was the argument that kernel
developers aren't placing markers in meaningful locations. This is a
simple patch to try and do that for the syscall case.
Presently LTTng attempts to litter these trace markers all over the
architecture code, primarily to get around the fact that there was no
generic way to get at this information before. Now that platforms are
starting to do their syscall entry/exit notifiers through tracehook and
we have the asm/syscall.h interface, all of this information can be
generically abstracted.
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
---
include/linux/tracehook.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/linux/tracehook.h b/include/linux/tracehook.h
index 6186a78..481ff45 100644
--- a/include/linux/tracehook.h
+++ b/include/linux/tracehook.h
@@ -49,6 +49,9 @@
#include <linux/sched.h>
#include <linux/ptrace.h>
#include <linux/security.h>
+#include <linux/marker.h>
+#include <asm/syscall.h>
+
struct linux_binprm;
/**
@@ -112,6 +115,8 @@ static inline __must_check int tracehook_report_syscall_entry(
struct pt_regs *regs)
{
ptrace_report_syscall(regs);
+ trace_mark(kernel_arch_syscall_entry, "syscall_id %ld ip #p%ld",
+ syscall_get_nr(NULL, regs), instruction_pointer(regs));
return 0;
}
@@ -135,6 +140,8 @@ static inline __must_check int tracehook_report_syscall_entry(
static inline void tracehook_report_syscall_exit(struct pt_regs *regs, int step)
{
ptrace_report_syscall(regs);
+ trace_mark(kernel_arch_syscall_exit, "ret %ld",
+ syscall_get_return_value(NULL, regs));
}
/**
next reply other threads:[~2008-09-21 2:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-21 2:16 Paul Mundt [this message]
2008-09-22 1:12 ` [PATCH] [RFC] tracehook: Hook in syscall tracing markers KOSAKI Motohiro
2008-09-23 1:20 ` Mathieu Desnoyers
2008-09-22 1:28 ` Frank Ch. Eigler
2008-09-23 1:22 ` Mathieu Desnoyers
2008-09-26 10:42 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080921021630.GA6443@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=compudj@krystal.dyndns.org \
--cc=fche@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox