From: Krishna Kumar <krkumar2@in.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Krishna Kumar <krkumar2@in.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [RFC] [PATCH 1/1]: timers: Change add_timer to use add_timer_on
Date: Mon, 22 Sep 2008 10:04:38 +0530 [thread overview]
Message-ID: <20080922043438.21118.93359.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20080922043425.21118.24172.sendpatchset@localhost.localdomain>
From: Krishna Kumar <krkumar2@in.ibm.com>
timer: Change add_timer to not check for existing timer.
Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
---
include/linux/timer.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -ruNp 2.6.27-rc7-org/include/linux/timer.h 2.6.27-rc7-new/include/linux/timer.h
--- 2.6.27-rc7-org/include/linux/timer.h 2008-09-17 17:40:36.000000000 +0530
+++ 2.6.27-rc7-new/include/linux/timer.h 2008-09-17 17:41:50.000000000 +0530
@@ -4,6 +4,7 @@
#include <linux/list.h>
#include <linux/ktime.h>
#include <linux/stddef.h>
+#include <linux/smp.h>
#include <linux/debugobjects.h>
struct tvec_base;
@@ -162,8 +163,7 @@ static inline void timer_stats_timer_cle
*/
static inline void add_timer(struct timer_list *timer)
{
- BUG_ON(timer_pending(timer));
- __mod_timer(timer, timer->expires);
+ add_timer_on(timer, raw_smp_processor_id());
}
#ifdef CONFIG_SMP
next prev parent reply other threads:[~2008-09-22 4:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 4:34 [RFC] [PATCH 0/1] timers: add_timer should never be called if pending Krishna Kumar
2008-09-22 4:34 ` Krishna Kumar [this message]
2008-09-22 14:43 ` [RFC] [PATCH 1/1]: timers: Change add_timer to use add_timer_on Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080922043438.21118.93359.sendpatchset@localhost.localdomain \
--to=krkumar2@in.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox