[Patch 1/3] Tracing/ftrace: Make nop tracer reset previous entries

[Patch 1/3] Tracing/ftrace: Make nop tracer reset previous entries

[Frédéric Weisbecker]

If nop tracer is selected, some old entries from the previous tracer could still be enqueued. Tracing have to be reset.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
diff -rup linux-2.6-tip (2)/kernel/trace/trace_nop.c linux-2.6-tip/kernel/trace/trace_nop.c
--- linux-2.6-tip (2)/kernel/trace/trace_nop.c	2008-09-19 18:01:26.000000000 +0200
+++ linux-2.6-tip/kernel/trace/trace_nop.c	2008-09-21 00:44:47.000000000 +0200
@@ -25,8 +25,12 @@ static void stop_nop_trace(struct trace_
 }

 

 static void nop_trace_init(struct trace_array *tr)

-{

-	ctx_trace = tr;

+{
+	int cpu;

+	ctx_trace = tr;
+
+	for_each_online_cpu(cpu)

+		tracing_reset(tr->data[cpu]);

 

 	if (tr->ctrl)

 		start_nop_trace(tr);

Re: [Patch 1/3] Tracing/ftrace: Make nop tracer reset previous entries

[KOSAKI Motohiro]

your patch seems corrupted.
please check again your e-mail client settings.


> If nop tracer is selected, some old entries from the previous tracer could still be enqueued. Tracing have to be reset.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> ---
> diff -rup linux-2.6-tip (2)/kernel/trace/trace_nop.c linux-2.6-tip/kernel/trace/trace_nop.c
> --- linux-2.6-tip (2)/kernel/trace/trace_nop.c	2008-09-19 18:01:26.000000000 +0200
> +++ linux-2.6-tip/kernel/trace/trace_nop.c	2008-09-21 00:44:47.000000000 +0200
> @@ -25,8 +25,12 @@ static void stop_nop_trace(struct trace_
>  }
> 
>  
> 
>  static void nop_trace_init(struct trace_array *tr)
> 
> -{
> 
> -	ctx_trace = tr;
> 
> +{
> +	int cpu;
> 
> +	ctx_trace = tr;
> +
> +	for_each_online_cpu(cpu)
> 
> +		tracing_reset(tr->data[cpu]);
> 
>  
> 
>  	if (tr->ctrl)
> 
>  		start_nop_trace(tr);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: [Patch 1/3] Tracing/ftrace: Make nop tracer reset previous entries

[Ingo Molnar]

* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

> your patch seems corrupted.
> please check again your e-mail client settings.

i fixed the extra newlines up and applied the patches to 
tip/tracing/ftrace, thanks Frédéric!

please check Documentation/email-clients.txt about details. There were 
two problems i saw: overlong lines in the commit description and extra 
'double newlines' in the patch itself. (To get around gmail limitations 
you can send -tip patches as MIME attachments as well.)

	Ingo

Re: [Patch 1/3] Tracing/ftrace: Make nop tracer reset previous entries

[Frédéric Weisbecker]

2008/9/22 Ingo Molnar <mingo@elte.hu>:
>
> * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
>
>> your patch seems corrupted.
>> please check again your e-mail client settings.
>
> i fixed the extra newlines up and applied the patches to
> tip/tracing/ftrace, thanks Frédéric!
>
> please check Documentation/email-clients.txt about details. There were
> two problems i saw: overlong lines in the commit description and extra
> 'double newlines' in the patch itself. (To get around gmail limitations
> you can send -tip patches as MIME attachments as well.)
>
>        Ingo
>

Oops. I'm really sorry about that. I was pretty convinced that my
email client was well configured.
In the future I will first send myself the patches before any new
submit to ensure they are not damaged...

Thanks.

Re: [Patch 1/3] Tracing/ftrace: Make nop tracer reset previous entries

[Ingo Molnar]

* Frédéric Weisbecker <fweisbec@gmail.com> wrote:

> 2008/9/22 Ingo Molnar <mingo@elte.hu>:
> >
> > * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> >
> >> your patch seems corrupted.
> >> please check again your e-mail client settings.
> >
> > i fixed the extra newlines up and applied the patches to
> > tip/tracing/ftrace, thanks Frédéric!
> >
> > please check Documentation/email-clients.txt about details. There were
> > two problems i saw: overlong lines in the commit description and extra
> > 'double newlines' in the patch itself. (To get around gmail limitations
> > you can send -tip patches as MIME attachments as well.)
> >
> >        Ingo
> >
> 
> Oops. I'm really sorry about that. I was pretty convinced that my
> email client was well configured.
> In the future I will first send myself the patches before any new
> submit to ensure they are not damaged...

no harm was done really, we can cope. I'd suggest you do the 
send-yourself thing once now to check that your practices are OK.

	Ingo