From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Krishna Kumar <krkumar2@in.ibm.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: do_generic_file_read() never gets a NULL 'filp' argument
Date: Mon, 22 Sep 2008 10:36:35 -0700 [thread overview]
Message-ID: <20080922103635.77d795e4.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080922083945.GA12658@infradead.org>
On Mon, 22 Sep 2008 04:39:46 -0400 Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Sep 22, 2008 at 01:33:38AM -0700, Andrew Morton wrote:
> > On Mon, 22 Sep 2008 11:46:10 +0530 Krishna Kumar <krkumar2@in.ibm.com> wrote:
> >
> > > From: Krishna Kumar <krkumar2@in.ibm.com>
> > >
> > > The 'filp' argument to do_generic_file_read() is never NULL.
> > >
> >
> > How did you verify this?
> >
> > NFS used to like passing NULL file*'s into VFS functions. I don't
> > recall whether it affected do_generic_file_read().
>
> The only thing nfsd passed a NULL file pointer in is ->fsync on
> directories.
NFS, not NFSD. It was page_cache_read(), iirc.
next prev parent reply other threads:[~2008-09-22 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 6:16 [PATCH] mm: do_generic_file_read() never gets a NULL 'filp' argument Krishna Kumar
2008-09-22 8:33 ` Andrew Morton
2008-09-22 8:39 ` Christoph Hellwig
2008-09-22 17:36 ` Andrew Morton [this message]
2008-09-23 11:00 ` KOSAKI Motohiro
2008-09-22 8:40 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080922103635.77d795e4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=krkumar2@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox