From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
Suresh Siddha <suresh.b.siddha@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH -tip/master] x86: io-apic - interrupt remapping fix
Date: Mon, 22 Sep 2008 14:37:36 +0400 [thread overview]
Message-ID: <20080922103736.GA22024@localhost> (raw)
In-Reply-To: <20080922100532.GD24705@elte.hu>
[Ingo Molnar - Mon, Sep 22, 2008 at 12:05:32PM +0200]
|
| * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
|
| > On Mon, Sep 22, 2008 at 2:04 AM, Ingo Molnar <mingo@elte.hu> wrote:
| >
| > BTW
| >
| > x2apic and IRmapping make io_apic.c and apic.c ugly.
|
| yes. Any ideas how to clean it up some more?
|
| the kmalloc looks quite ugly, especially with this kfree() teardown
| sequence we have now.
|
| Ingo
|
yes Ingo - it's ugly but I had not that many choises:
1) allocate/deallocate if failed inside same routine
2) deallocate in restore_IO_APIC_setup (which would be much more
ugly and obscure)
3) allocate and deallocate in completely separated routines - didn't
even tried :)
So I've stopped on (1) 'case it was less_changing_the_sources patch.
- Cyrill -
next prev parent reply other threads:[~2008-09-22 10:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 12:33 [PATCH -tip/master] x86: io-apic - interrupt remapping fix Cyrill Gorcunov
2008-09-22 9:04 ` Ingo Molnar
2008-09-22 10:01 ` Yinghai Lu
2008-09-22 10:05 ` Ingo Molnar
2008-09-22 10:37 ` Cyrill Gorcunov [this message]
2008-09-23 1:19 ` Suresh Siddha
2008-09-23 0:57 ` Suresh Siddha
2008-09-23 1:16 ` Suresh Siddha
2008-09-23 4:56 ` Cyrill Gorcunov
2008-09-23 18:34 ` Suresh Siddha
2008-09-23 18:42 ` Cyrill Gorcunov
2008-09-23 19:00 ` Cyrill Gorcunov
2008-09-23 19:17 ` Suresh Siddha
2008-09-27 16:54 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080922103736.GA22024@localhost \
--to=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox