Re: mmotm 2008-09-22-01-36 uploaded (memory_hotplug)

Andrew Morton
2008-09-23T22:19:17Z

On Tue, 23 Sep 2008 15:08:22 -0700
Badari Pulavarty <pbadari@us.ibm.com> wrote:

> > > so it is defined in both mm/memory_hotplug.c and
> > > arch/x86/mm/init_64.c when CONFIG_MEMORY_HOTREMOVE=y.
> > >
> >
> > OK, thanks, it looks like people are changing things under our feet.
> >
> > Badari, can you please check this fix against
> > mm-cleanup-to-make-remove_memory-arch-neutral.patch?
> >
>
>
> When I made the patch, only ppc64, ia64 and s390 had
> memory_remove() support in mainline. I sent a patch against
> x86 to add hotplug memory remove support. I guess you
> merged Gary's patch and sh-arch patch.
>
> I noticed that you cleaned up all these and added to -mm.
> Do you want me to merge all these into a single patch and
> resend it (against -mm) ?

No, that's OK.

> (It will look exactly the same
> anyway).

Does that mean you reviewed all the fixes I added? We're sure that all
the per-arch implementations of remove_memory() can be replaced by the
generic one?