Re: [PATCH 1/2] file capabilities: add no_file_caps switch (v2)

[Andreas Gruenbacher <agruen@suse.de>]

On Monday 22 September 2008 21:16:04 Stephen Smalley wrote:
> On Mon, 2008-09-22 at 13:48 -0500, Serge E. Hallyn wrote:
> > (Resend of two patches from late August.  If noone objects, would it be
> > possible to see this pair take a turn in security-testing?)
> >
> > Add a no_file_caps boot option when file capabilities are
> > compiled into the kernel (CONFIG_SECURITY_FILE_CAPABILITIES=y).
>
> Is there a reason you didn't just use a filecaps=0/1 approach ala the
> selinux= boot parameter?  And let the default value be selectable as
> well?

Sure, that would work as well, except that I think that file capabilities 
should always default to "on" as they will become a standard security 
mechanism before long. We just don't have much system management tool support 
yet, and I would like to give that some more time safely, without putting 
users at unnecessary risk.

I think we could get rid of the command line option again in a year or two ...

> Seems a bit confusing to offer a no_file_caps option with different
> behavior than disabling it at build time.

I agree. These other behaviorial changes should not depend on 
CONFIG_SECURITY_FILE_CAPABILITIES; the old behavior should just be fixed 
instead.

Thanks,
Andreas