From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754916AbYIVXll (ORCPT ); Mon, 22 Sep 2008 19:41:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754069AbYIVXlc (ORCPT ); Mon, 22 Sep 2008 19:41:32 -0400 Received: from ipmail04.adl2.internode.on.net ([203.16.214.57]:47610 "EHLO ipmail04.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753096AbYIVXlb (ORCPT ); Mon, 22 Sep 2008 19:41:31 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEALLH10h5LF82/2dsb2JhbAC2dIFm X-IronPort-AV: E=Sophos;i="4.32,448,1217773800"; d="scan'208";a="212717214" Date: Tue, 23 Sep 2008 09:41:20 +1000 From: Dave Chinner To: Takashi Sato Cc: Andrew Morton , Christoph Hellwig , "linux-fsdevel@vger.kernel.org" , "dm-devel@redhat.com" , "viro@ZenIV.linux.org.uk" , "linux-ext4@vger.kernel.org" , "xfs@oss.sgi.com" , "axboe@kernel.dk" , "mtk.manpages@googlemail.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 4/10] xfs: Fix error handling in write_super_lockfs/unlockfs Message-ID: <20080922234120.GV5811@disturbed> Mail-Followup-To: Takashi Sato , Andrew Morton , Christoph Hellwig , "linux-fsdevel@vger.kernel.org" , "dm-devel@redhat.com" , "viro@ZenIV.linux.org.uk" , "linux-ext4@vger.kernel.org" , "xfs@oss.sgi.com" , "axboe@kernel.dk" , "mtk.manpages@googlemail.com" , "linux-kernel@vger.kernel.org" References: <20080922195637t-sato@mail.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080922195637t-sato@mail.jp.nec.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 22, 2008 at 07:56:37PM +0900, Takashi Sato wrote: > I've changed write_super_lockfs/unlockfs so that they always return > 0 (success) to keep a current behavior. > > Signed-off-by: Takashi Sato > Signed-off-by: Masayuki Hamaguchi > --- > xfs_super.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff -uprN -X linux-2.6.27-rc7-lockfs/Documentation/dontdiff linux-2.6.27-rc7-lockfs/fs/xfs/linux-2.6/xfs_super.c linux- > 2.6.27-rc7-lockfs-xfs/fs/xfs/linux-2.6/xfs_super.c > --- linux-2.6.27-rc7-lockfs/fs/xfs/linux-2.6/xfs_super.c 2008-09-22 07:29:55.000000000 +0900 > +++ linux-2.6.27-rc7-lockfs-xfs/fs/xfs/linux-2.6/xfs_super.c 2008-09-22 10:13:39.000000000 +0900 > @@ -1351,7 +1351,7 @@ xfs_fs_remount( > * need to take care of themetadata. Once that's done write a dummy > * record to dirty the log in case of a crash while frozen. > */ > -STATIC void > +STATIC int > xfs_fs_lockfs( > struct super_block *sb) > { > @@ -1359,6 +1359,7 @@ xfs_fs_lockfs( > > xfs_attr_quiesce(mp); > xfs_fs_log_dummy(mp); > + return 0; > } xfs_fs_log_dummy() currently is void because it had nowhere to return errors to. It silently throws away errors because of this. Hence the correct thing to do here is to fix xfs_fs_log_dummy() to return the errors it currently ignores. i.e. catch the errors from xfs_trans_reserve() and xfs_trans_commit() calls in xfs_fs_log_dummy(). Cheers, Dave. -- Dave Chinner david@fromorbit.com