From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, Hugh Dickins <hugh@veritas.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
"Randy.Dunlap" <rdunlap@xenotime.net>
Subject: Re: [PATCH 1/2] corruption check: move the corruption checks into their own file
Date: Tue, 23 Sep 2008 10:36:43 +0200 [thread overview]
Message-ID: <20080923083643.GF23031@elte.hu> (raw)
In-Reply-To: <20080922195810.624d777a@infradead.org>
* Arjan van de Ven <arjan@infradead.org> wrote:
> updated patch based on feedback from Randy that I should fix
> whitespace issues while moving code
but that's wrong. You should _never_ change code while moving it because
it's utterly unreviewable. Please split into two patches: first move the
code, then do the style cleanups in the target file.
also, could you please rename the new file to check.c - it's shorter and
we might check other things there too.
Ingo
next prev parent reply other threads:[~2008-09-23 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-23 2:58 [PATCH 1/2] corruption check: move the corruption checks into their own file Arjan van de Ven
2008-09-23 2:58 ` [PATCH 2/2] corruption check: run the corruption checks from a work queue Arjan van de Ven
2008-09-23 6:03 ` Jeremy Fitzhardinge
2008-09-23 8:36 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-21 3:35 [PATCH] x86: use round_jiffies() for the corruption check timer Arjan van de Ven
2008-09-22 21:04 ` [PATCH 1/2] corruption check: move the corruption checks into their own file Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080923083643.GF23031@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@infradead.org \
--cc=hugh@veritas.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox