From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@infradead.org>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>,
linux-kernel@vger.kernel.org, Hugh Dickins <hugh@veritas.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Subject: Re: [PATCH 2/2] corruption check: run the corruption checks from a work queue
Date: Tue, 23 Sep 2008 13:33:03 +0200 [thread overview]
Message-ID: <20080923113303.GA14840@elte.hu> (raw)
In-Reply-To: <20080922163914.2cafd797@infradead.org>
* Arjan van de Ven <arjan@infradead.org> wrote:
> On Mon, 22 Sep 2008 16:28:23 -0700 (PDT)
> "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
>
> > On Mon, 22 Sep 2008, Arjan van de Ven wrote:
> >
> > > eh a stray debug // snuck in; update attached
> >
> > In that case, patch 1/2 contains "for(" and "while(". :(
> >
>
> that's a dillema case.
> I'm just moving code around in patch 1/2; I personally consider it bad
> form to also change it at the same time.....
>
> (and it confuses git change tracking)
correct. The right solution in this case (where code is moved around) to
do a separate patch for the style errors Randy reported, once the code
has been moved over.
Ingo
next prev parent reply other threads:[~2008-09-23 11:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-21 3:35 [PATCH] x86: use round_jiffies() for the corruption check timer Arjan van de Ven
2008-09-22 8:29 ` Ingo Molnar
2008-09-22 21:04 ` [PATCH 1/2] corruption check: move the corruption checks into their own file Arjan van de Ven
2008-09-22 21:05 ` [PATCH 2/2] corruption check: run the corruption checks from a work queue Arjan van de Ven
2008-09-22 23:24 ` Arjan van de Ven
2008-09-22 23:28 ` Randy.Dunlap
2008-09-22 23:39 ` Arjan van de Ven
2008-09-23 11:33 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-23 2:58 [PATCH 1/2] corruption check: move the corruption checks into their own file Arjan van de Ven
2008-09-23 2:58 ` [PATCH 2/2] corruption check: run the corruption checks from a work queue Arjan van de Ven
2008-09-23 6:03 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080923113303.GA14840@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@infradead.org \
--cc=hugh@veritas.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox