public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: jbarnes@virtuousgeek.org, kristen.c.accardi@intel.com,
	matthew@wil.cx, kaneshige.kenji@jp.fujitsu.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 00/14] PCI: let the core manage slot names
Date: Tue, 23 Sep 2008 10:45:13 -0600	[thread overview]
Message-ID: <20080923163753.12628.98683.stgit@bob.kio> (raw)

Hi Jesse, Kenji, et al,

This is v3 of the series that implements a series of changes
that allows the PCI core to manage slot names, rather than
individual hotplug drivers.

v2 -> v3:
	- incorporate Willy's code review comments
	- fix possible memory leak, pointed out by Rolf Eike Beer
	- make false name collision detection work for empty slots
	- add 'dup_slots' module_param to fakephp to help debug all this ;)

v1 -> v2:
	- fix possible false name collisions

This series applies against linux-next. I've tested this by loading
pci_slot and various hotplug drivers to ensure that the hotplug drivers
can successfully override the pci_slot names.

I'm including the previous explanation/justification to remind
folks of the raison d'etre for this patchset.

Thanks.

/ac

There are several benefits to this approach:

	1) The core can prevent duplicate slot names on systems
	with broken firmware.

	2) Since the kobject core keeps a copy of the slot name,
	there is no need for each driver to manage a separate
	copy, especially since the core can rename slots from
	underneath drivers. We save runtime memory by only
	referencing the kobject name.

	2.a) The PCI hotplug core doesn't need its own reference
	for slot name either.

	3) Individual hotplug drivers become just a little bit
	simpler by pushing as many kzalloc() calls for 'name'
	down into the PCI core as possible.

---

Alex Chiang (14):
      PCI Hotplug: fakephp: add duplicate slot name debugging
      PCI: Hotplug core: remove 'name'
      PCI: shcphp: remove 'name' parameter
      PCI: SGI Hotplug: stop managing bss_hotplug_slot->name
      PCI: rpaphp: stop managing hotplug_slot->name
      PCI: pciehp: remove 'name' parameter
      PCI: ibmphp: stop managing hotplug_slot->name
      PCI: fakephp: remove 'name' parameter
      PCI: cpqphp: stop managing hotplug_slot->name
      PCI: cpci_hotplug: stop managing hotplug_slot->name
      PCI: acpiphp: remove 'name' parameter
      PCI, PCI Hotplug: introduce slot_name helpers
      PCI: prevent duplicate slot names
      PCI Hotplug core: add 'name' param pci_hp_register interface


 drivers/pci/hotplug/acpiphp.h           |    9 +-
 drivers/pci/hotplug/acpiphp_core.c      |   32 +++---
 drivers/pci/hotplug/cpci_hotplug.h      |    6 +
 drivers/pci/hotplug/cpci_hotplug_core.c |   74 +++++---------
 drivers/pci/hotplug/cpci_hotplug_pci.c  |    4 -
 drivers/pci/hotplug/cpqphp.h            |   13 +-
 drivers/pci/hotplug/cpqphp_core.c       |   42 ++++----
 drivers/pci/hotplug/fakephp.c           |   25 +++--
 drivers/pci/hotplug/ibmphp.h            |    5 -
 drivers/pci/hotplug/ibmphp_ebda.c       |   19 +---
 drivers/pci/hotplug/pci_hotplug_core.c  |   62 ++++++------
 drivers/pci/hotplug/pciehp.h            |    9 +-
 drivers/pci/hotplug/pciehp_core.c       |   41 +++-----
 drivers/pci/hotplug/pciehp_ctrl.c       |   53 +++++-----
 drivers/pci/hotplug/pciehp_hpc.c        |    1 
 drivers/pci/hotplug/rpaphp.h            |   10 +-
 drivers/pci/hotplug/rpaphp_core.c       |    6 +
 drivers/pci/hotplug/rpaphp_pci.c        |    4 -
 drivers/pci/hotplug/rpaphp_slot.c       |   26 ++---
 drivers/pci/hotplug/sgi_hotplug.c       |   18 +--
 drivers/pci/hotplug/shpchp.h            |    9 +-
 drivers/pci/hotplug/shpchp_core.c       |   42 +++-----
 drivers/pci/hotplug/shpchp_ctrl.c       |   48 ++++-----
 drivers/pci/slot.c                      |  167 +++++++++++++++++++++++--------
 include/linux/pci.h                     |    9 +-
 include/linux/pci_hotplug.h             |   13 ++
 26 files changed, 401 insertions(+), 346 deletions(-)


             reply	other threads:[~2008-09-23 16:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-23 16:45 Alex Chiang [this message]
2008-09-23 16:45 ` [PATCH v3 01/14] PCI Hotplug core: add 'name' param pci_hp_register interface Alex Chiang
2008-09-23 16:45 ` [PATCH v3 02/14] PCI: prevent duplicate slot names Alex Chiang
     [not found]   ` <48E09936.2030905@jp.fujitsu.com>
2008-09-30  2:06     ` Kenji Kaneshige
2008-10-02  1:05       ` Alex Chiang
2008-10-02  2:47         ` Kenji Kaneshige
2008-10-02  4:48           ` Alex Chiang
2008-10-03  1:33             ` Kenji Kaneshige
2008-09-23 16:45 ` [PATCH v3 03/14] PCI, PCI Hotplug: introduce slot_name helpers Alex Chiang
2008-09-23 16:45 ` [PATCH v3 04/14] PCI: acpiphp: remove 'name' parameter Alex Chiang
2008-09-23 16:45 ` [PATCH v3 05/14] PCI: cpci_hotplug: stop managing hotplug_slot->name Alex Chiang
2008-09-23 16:45 ` [PATCH v3 06/14] PCI: cpqphp: " Alex Chiang
2008-09-23 16:45 ` [PATCH v3 07/14] PCI: fakephp: remove 'name' parameter Alex Chiang
2008-09-23 16:45 ` [PATCH v3 08/14] PCI: ibmphp: stop managing hotplug_slot->name Alex Chiang
2008-09-23 16:45 ` [PATCH v3 09/14] PCI: pciehp: remove 'name' parameter Alex Chiang
2008-09-23 16:46 ` [PATCH v3 10/14] PCI: rpaphp: stop managing hotplug_slot->name Alex Chiang
2008-09-23 16:46 ` [PATCH v3 11/14] PCI: SGI Hotplug: stop managing bss_hotplug_slot->name Alex Chiang
2008-09-23 16:46 ` [PATCH v3 12/14] PCI: shcphp: remove 'name' parameter Alex Chiang
2008-09-23 16:46 ` [PATCH v3 13/14] PCI: Hotplug core: remove 'name' Alex Chiang
2008-09-23 16:46 ` [PATCH v3 14/14] PCI Hotplug: fakephp: add duplicate slot name debugging Alex Chiang
2008-09-24  8:47 ` [PATCH v3 00/14] PCI: let the core manage slot names Kenji Kaneshige
2008-09-26  8:06 ` Taku Izumi
2008-10-01 21:04   ` Alex Chiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080923163753.12628.98683.stgit@bob.kio \
    --to=achiang@hp.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox