From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH -tip/master] x86: io-apic - interrupt remapping fix
Date: Tue, 23 Sep 2008 12:17:43 -0700 [thread overview]
Message-ID: <20080923191742.GA15609@linux-os.sc.intel.com> (raw)
In-Reply-To: <20080923190002.GE10567@localhost>
On Tue, Sep 23, 2008 at 12:00:02PM -0700, Cyrill Gorcunov wrote:
> ---
> From: Cyrill Gorcunov <gorcunov@gmail.com>
>
> Clean up obscure for() cycle with straight while() form
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> CC: Suresh Siddha <suresh.b.siddha@intel.com>
> ---
>
> Index: linux-2.6.git/arch/x86/kernel/io_apic.c
> ===================================================================
> --- linux-2.6.git.orig/arch/x86/kernel/io_apic.c 2008-09-22 17:42:33.000000000 +0400
> +++ linux-2.6.git/arch/x86/kernel/io_apic.c 2008-09-23 22:45:58.000000000 +0400
> @@ -830,9 +830,8 @@ int save_mask_IO_APIC_setup(void)
> return 0;
>
> nomem:
> - for (; apic > 0; apic--)
> - kfree(early_ioapic_entries[apic]);
> - kfree(early_ioapic_entries[apic]);
> + while (apic >= 0)
> + kfree(early_ioapic_entries[apic--]);
> memset(early_ioapic_entries, 0,
> ARRAY_SIZE(early_ioapic_entries));
>
looks better. thanks.
next prev parent reply other threads:[~2008-09-23 19:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 12:33 [PATCH -tip/master] x86: io-apic - interrupt remapping fix Cyrill Gorcunov
2008-09-22 9:04 ` Ingo Molnar
2008-09-22 10:01 ` Yinghai Lu
2008-09-22 10:05 ` Ingo Molnar
2008-09-22 10:37 ` Cyrill Gorcunov
2008-09-23 1:19 ` Suresh Siddha
2008-09-23 0:57 ` Suresh Siddha
2008-09-23 1:16 ` Suresh Siddha
2008-09-23 4:56 ` Cyrill Gorcunov
2008-09-23 18:34 ` Suresh Siddha
2008-09-23 18:42 ` Cyrill Gorcunov
2008-09-23 19:00 ` Cyrill Gorcunov
2008-09-23 19:17 ` Suresh Siddha [this message]
2008-09-27 16:54 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080923191742.GA15609@linux-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox