From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Steven Rostedt <rostedt@goodmis.org>,
Harvey Harrison <harvey.harrison@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: suppress trivial sparse signedness warnings
Date: Tue, 23 Sep 2008 19:46:56 -0400 [thread overview]
Message-ID: <20080923234656.GA26986@Krystal> (raw)
In-Reply-To: <1222207546.16003.21.camel@brick>
This should probably go to Steven...
* Harvey Harrison (harvey.harrison@gmail.com) wrote:
> Could just as easily change the three casts to cast to the correct
> type...this patch changes the type of ftrace_nop instead.
>
> Supresses sparse warnings:
> arch/x86/kernel/ftrace.c:157:14: warning: incorrect type in assignment (different signedness)
> arch/x86/kernel/ftrace.c:157:14: expected long *static [toplevel] ftrace_nop
> arch/x86/kernel/ftrace.c:157:14: got unsigned long *<noident>
> arch/x86/kernel/ftrace.c:161:14: warning: incorrect type in assignment (different signedness)
> arch/x86/kernel/ftrace.c:161:14: expected long *static [toplevel] ftrace_nop
> arch/x86/kernel/ftrace.c:161:14: got unsigned long *<noident>
> arch/x86/kernel/ftrace.c:165:14: warning: incorrect type in assignment (different signedness)
> arch/x86/kernel/ftrace.c:165:14: expected long *static [toplevel] ftrace_nop
> arch/x86/kernel/ftrace.c:165:14: got unsigned long *<noident>
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> arch/x86/kernel/ftrace.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c
> index 082d996..66d9002 100644
> --- a/arch/x86/kernel/ftrace.c
> +++ b/arch/x86/kernel/ftrace.c
> @@ -22,7 +22,7 @@
>
>
> /* Long is fine, even if it is only 4 bytes ;-) */
> -static long *ftrace_nop;
> +static unsigned long *ftrace_nop;
>
> union ftrace_code_union {
> char code[MCOUNT_INSN_SIZE];
> --
> 1.6.0.2.471.g47a76
>
>
>
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2008-09-23 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-23 22:05 [PATCH] x86: suppress trivial sparse signedness warnings Harvey Harrison
2008-09-23 23:46 ` Mathieu Desnoyers [this message]
2008-09-24 7:55 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080923234656.GA26986@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox