From: Ingo Molnar <mingo@elte.hu>
To: "Frédéric Weisbecker" <fweisbec@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Steven Noonan <steven@uplinklabs.net>,
Arjan van de Ven <arjan@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [Patch -tip 0/4] Creation of the initcall tracer
Date: Wed, 24 Sep 2008 10:58:48 +0200 [thread overview]
Message-ID: <20080924085848.GA22251@elte.hu> (raw)
In-Reply-To: <48DA0A09.5080709@gmail.com>
* Frédéric Weisbecker <fweisbec@gmail.com> wrote:
> Ingo Molnar a écrit :
> > * Ingo Molnar <mingo@elte.hu> wrote:
> >
> >> i've integrated tip/tracing/fastboot into tip/master and have started
> >> testing it. It passed the basic tests already so i've just pushed out
> >> the new tip/master. Please double-check that i have not messed up the
> >> rename or the integration somewhere.
> >
> > FYI, -tip testing found a boot hang with CONFIG_BOOT_TRACER=y, on a
> > 32-bit T60 laptop. I've attached the config that provokes the hang. (you
> > need initcall_debug on the boot commandline)
> >
> > The hang always happens after a specific initcall, shortly after tracing
> > is enabled. It just hangs indefinitely there, the last line displayed
> > was:
> >
> > [ 0.004017] initcall ehci_hcd_init+0x0/0x80 returned 0 after 228 msecs
> >
> > it should have printed this next:
> >
> > [ 0.808024] calling ohci_hcd_mod_init+0x0/0x80 @ 10
> >
> > but that line is never printed.
> >
> > i've bisected the hang down to this specific commit:
> >
> > | 35df98dfe2b2503436a8cfda301657810df50a3a is first bad commit
> > | commit 35df98dfe2b2503436a8cfda301657810df50a3a
> > | Author: Frédéric Weisbecker <fweisbec@gmail.com>
> > | Date: Tue Sep 23 11:38:18 2008 +0100
> > |
> > | tracing/ftrace: launch boot tracing after pre-smp initcalls
> >
> > An idea: maybe the boot tracer is interacting with the ftrace self-tests
> > somehow? CONFIG_FTRACE_SELFTEST=y is enabled.
> >
> > another thing i noticed is that the sysprof tracer was initialized and
> > self-tested shortly before the hang occured. Might be unrelated.
> >
> > the bisection log is:
> >
> > # bad: [6522eab5] Merge branch 'x86/uv'
> > # good: [699b81f5] Merge branch 'x86/iommu'
> > # bad: [8007aae9] timers: fix build error in !oneshot case
> > # good: [7f29b23d] Merge branch 'core/rcu'
> > # bad: [a54f17e3] manual merge of tracing/fastboot
> > # good: [bcbbe946] tracing/ftrace: make tracing suitable to run the b
> > # good: [d7095e5a] Merge branch 'fastboot'
> > # bad: [35df98df] tracing/ftrace: launch boot tracing after pre-smp
> > # good: [42aaa6be] tracing/ftrace: give an entry on the config for bo
> >
> > Ingo
> >
> Ingo Molnar a écrit :
> > * Ingo Molnar <mingo@elte.hu> wrote:
> >
> >> i've integrated tip/tracing/fastboot into tip/master and have started
> >> testing it. It passed the basic tests already so i've just pushed out
> >> the new tip/master. Please double-check that i have not messed up the
> >> rename or the integration somewhere.
> >
> > FYI, -tip testing found a boot hang with CONFIG_BOOT_TRACER=y, on a
> > 32-bit T60 laptop. I've attached the config that provokes the hang. (you
> > need initcall_debug on the boot commandline)
> >
> > The hang always happens after a specific initcall, shortly after tracing
> > is enabled. It just hangs indefinitely there, the last line displayed
> > was:
> >
> > [ 0.004017] initcall ehci_hcd_init+0x0/0x80 returned 0 after 228 msecs
> >
> > it should have printed this next:
> >
> > [ 0.808024] calling ohci_hcd_mod_init+0x0/0x80 @ 10
> >
> > but that line is never printed.
> >
> > i've bisected the hang down to this specific commit:
> >
> > | 35df98dfe2b2503436a8cfda301657810df50a3a is first bad commit
> > | commit 35df98dfe2b2503436a8cfda301657810df50a3a
> > | Author: Frédéric Weisbecker <fweisbec@gmail.com>
> > | Date: Tue Sep 23 11:38:18 2008 +0100
> > |
> > | tracing/ftrace: launch boot tracing after pre-smp initcalls
> >
> > An idea: maybe the boot tracer is interacting with the ftrace self-tests
> > somehow? CONFIG_FTRACE_SELFTEST=y is enabled.
> >
> > another thing i noticed is that the sysprof tracer was initialized and
> > self-tested shortly before the hang occured. Might be unrelated.
> >
> > the bisection log is:
> >
> > # bad: [6522eab5] Merge branch 'x86/uv'
> > # good: [699b81f5] Merge branch 'x86/iommu'
> > # bad: [8007aae9] timers: fix build error in !oneshot case
> > # good: [7f29b23d] Merge branch 'core/rcu'
> > # bad: [a54f17e3] manual merge of tracing/fastboot
> > # good: [bcbbe946] tracing/ftrace: make tracing suitable to run the b
> > # good: [d7095e5a] Merge branch 'fastboot'
> > # bad: [35df98df] tracing/ftrace: launch boot tracing after pre-smp
> > # good: [42aaa6be] tracing/ftrace: give an entry on the config for bo
> >
> > Ingo
> >
>
> Hehe! I was preparing a patch because I saw last night that the self-tests were reseting and touching the ring-buffer during the initcall tracing.
> And now I can see the results of this problem....
>
> Following is a patch that should fix it.
applied to tip/tracing/fastboot, thanks Frédéric!
Ingo
prev parent reply other threads:[~2008-09-24 8:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-23 10:29 [Patch -tip 0/4] Creation of the initcall tracer Frédéric Weisbecker
2008-09-23 10:00 ` Ingo Molnar
2008-09-23 11:42 ` Frédéric Weisbecker
2008-09-23 19:31 ` Ingo Molnar
2008-09-24 9:36 ` Frédéric Weisbecker
2008-09-24 8:58 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080924085848.GA22251@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@infradead.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=steven@uplinklabs.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox