From: Joerg Roedel <joerg.roedel@amd.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, andi@firstfloor.org
Subject: Re: [PATCH 0/3] x86: restore old GART alloc_coherent
Date: Wed, 24 Sep 2008 14:58:08 +0200 [thread overview]
Message-ID: <20080924125808.GU24392@amd.com> (raw)
In-Reply-To: <1222256917-14321-1-git-send-email-fujita.tomonori@lab.ntt.co.jp>
On Wed, Sep 24, 2008 at 08:48:34PM +0900, FUJITA Tomonori wrote:
> This pachset is against tip/iommu.
>
> What this patchset does is restoring old GART alloc_coherent behavior
> (before the alloc_coherent rewrite):
>
> http://lkml.org/lkml/2008/8/12/200
>
> Currently, GART alloc_coherent tries to allocate pages with GFP_DMA32
> for a device having dma_masks > 24bit < 32bits. If GART gets an
> address that a device can't access to, GART tries to map the address
> to a virtual I/O address that the device can access to.
>
> But Andi pointed out, "The GART is somewhere in the 4GB range so you
> cannot use it to map anything < 4GB. Also GART is pretty small."
>
> http://lkml.org/lkml/2008/9/12/43
>
> So it's possible that GART doesn't have virtual I/O address space that
> a device can access to. The current behavior might not work for a
> device having dma_masks > 24bit < 32bits. This patchset restores old
> GART alloc_coherent behavior, which doesn't use GART hardware (if an
> user doesn't enable force_iommu option).
Acked-by: Joerg Roedel <joerg.roedel@amd.com>
--
| AMD Saxony Limited Liability Company & Co. KG
Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
System | Register Court Dresden: HRA 4896
Research | General Partner authorized to represent:
Center | AMD Saxony LLC (Wilmington, Delaware, US)
| General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy
next prev parent reply other threads:[~2008-09-24 12:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 11:48 [PATCH 0/3] x86: restore old GART alloc_coherent FUJITA Tomonori
2008-09-24 11:48 ` [PATCH 1/3] x86: export pci-nommu's alloc_coherent FUJITA Tomonori
2008-09-24 11:48 ` [PATCH 2/3] revert "x86: make GART to respect device's dma_mask about virtual mappings" FUJITA Tomonori
2008-09-24 11:48 ` [PATCH 3/3] x86: restore old GART alloc_coherent behavior FUJITA Tomonori
2008-09-24 12:11 ` Joerg Roedel
2008-09-24 12:43 ` FUJITA Tomonori
2008-09-24 12:57 ` Joerg Roedel
2008-09-24 13:06 ` Alan Cox
2008-09-24 22:01 ` Andi Kleen
2008-09-24 12:58 ` Joerg Roedel [this message]
2008-09-25 9:04 ` [PATCH 0/3] x86: restore old GART alloc_coherent Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080924125808.GU24392@amd.com \
--to=joerg.roedel@amd.com \
--cc=andi@firstfloor.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox