[PATCH 7/7] x86: print out irq nr for msi/ht -v2

[PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Yinghai Lu]

v2: fix hpet compiling

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
---
 arch/x86/kernel/hpet.c    |    3 +++
 arch/x86/kernel/io_apic.c |    7 +++++++
 2 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
index 422c577..686505a 100644
--- a/arch/x86/kernel/hpet.c
+++ b/arch/x86/kernel/hpet.c
@@ -467,6 +467,9 @@ static int hpet_setup_irq(struct hpet_dev *dev)
 	irq_set_affinity(dev->irq, cpumask_of_cpu(dev->cpu));
 	enable_irq(dev->irq);
 
+	printk(KERN_DEBUG "hpet: %s is using irq %#x aka %d for MSI\n",
+			 dev->name, dev->irq, dev->irq);
+
 	return 0;
 }
 
diff --git a/arch/x86/kernel/io_apic.c b/arch/x86/kernel/io_apic.c
index 4cc9cb6..dc82397 100644
--- a/arch/x86/kernel/io_apic.c
+++ b/arch/x86/kernel/io_apic.c
@@ -3355,6 +3355,9 @@ static int setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc, int irq)
 #endif
 		set_irq_chip_and_handler_name(irq, &msi_chip, handle_edge_irq, "edge");
 
+	printk(KERN_DEBUG "PCI: %s is using irq %#x aka %d for MSI/MSI-X\n",
+			 pci_name(dev), irq, irq);
+
 	return 0;
 }
 
@@ -3587,6 +3590,7 @@ int arch_setup_hpet_msi(unsigned int irq)
 	hpet_msi_write(irq, &msg);
 	set_irq_chip_and_handler_name(irq, &hpet_msi_type, handle_edge_irq,
 		"edge");
+
 	return 0;
 }
 #endif
@@ -3683,6 +3687,9 @@ int arch_setup_ht_irq(unsigned int irq, struct pci_dev *dev)
 
 		set_irq_chip_and_handler_name(irq, &ht_irq_chip,
 					      handle_edge_irq, "edge");
+
+		printk(KERN_DEBUG "PCI: %s is using irq %#x aka %d for HT\n",
+				 pci_name(dev), irq, irq);
 	}
 	return err;
 }
-- 
1.5.6

Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Ingo Molnar]

* Yinghai Lu <yhlu.kernel@gmail.com> wrote:

> v2: fix hpet compiling
> 
> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
> ---
>  arch/x86/kernel/hpet.c    |    3 +++
>  arch/x86/kernel/io_apic.c |    7 +++++++
>  2 files changed, 10 insertions(+), 0 deletions(-)

applied to tip/irq/sparseirq, thanks Yinghai.

	Ingo

Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Ingo Molnar]

> > v2: fix hpet compiling

still bad:

arch/x86/kernel/hpet.c: In function ‘hpet_late_init’:
arch/x86/kernel/hpet.c:828: error: ‘dev’ undeclared (first use in this function)
arch/x86/kernel/hpet.c:828: error: (Each undeclared identifier is reported only once
arch/x86/kernel/hpet.c:828: error: for each function it appears in.)

we've got some changes in this area (per cpu hpet).

	Ingo

Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Yinghai Lu]

On Thu, Sep 25, 2008 at 2:12 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
>> > v2: fix hpet compiling
>
> still bad:
>
> arch/x86/kernel/hpet.c: In function 'hpet_late_init':
> arch/x86/kernel/hpet.c:828: error: 'dev' undeclared (first use in this function)
> arch/x86/kernel/hpet.c:828: error: (Each undeclared identifier is reported only once
> arch/x86/kernel/hpet.c:828: error: for each function it appears in.)
>
> we've got some changes in this area (per cpu hpet).

will check it.

YH

Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Yinghai Lu]

On Thu, Sep 25, 2008 at 2:12 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
>> > v2: fix hpet compiling
>
> still bad:
>
> arch/x86/kernel/hpet.c: In function 'hpet_late_init':
> arch/x86/kernel/hpet.c:828: error: 'dev' undeclared (first use in this function)
> arch/x86/kernel/hpet.c:828: error: (Each undeclared identifier is reported only once
> arch/x86/kernel/hpet.c:828: error: for each function it appears in.)
>
> we've got some changes in this area (per cpu hpet).
>

looks there is some merge problem.

Index: linux-2.6/arch/x86/kernel/hpet.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/hpet.c
+++ linux-2.6/arch/x86/kernel/hpet.c
@@ -467,6 +467,9 @@ static int hpet_setup_irq(struct hpet_de
        irq_set_affinity(dev->irq, cpumask_of_cpu(dev->cpu));
        enable_irq(dev->irq);

+       printk(KERN_DEBUG "hpet: %s is using irq %#x aka %d for MSI\n",
+                        dev->name, dev->irq, dev->irq);
+
        return 0;
 }

the change should be in hpet_setup_irq instead of hpet_late_init

the patch can be applied to tip/master cleanly.

YH

Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Ingo Molnar]

* Yinghai Lu <yinghai@kernel.org> wrote:

> On Thu, Sep 25, 2008 at 2:12 AM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> >> > v2: fix hpet compiling
> >
> > still bad:
> >
> > arch/x86/kernel/hpet.c: In function 'hpet_late_init':
> > arch/x86/kernel/hpet.c:828: error: 'dev' undeclared (first use in this function)
> > arch/x86/kernel/hpet.c:828: error: (Each undeclared identifier is reported only once
> > arch/x86/kernel/hpet.c:828: error: for each function it appears in.)
> >
> > we've got some changes in this area (per cpu hpet).
> >
> 
> looks there is some merge problem.
> 
> Index: linux-2.6/arch/x86/kernel/hpet.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/hpet.c
> +++ linux-2.6/arch/x86/kernel/hpet.c
> @@ -467,6 +467,9 @@ static int hpet_setup_irq(struct hpet_de
>         irq_set_affinity(dev->irq, cpumask_of_cpu(dev->cpu));
>         enable_irq(dev->irq);
> 
> +       printk(KERN_DEBUG "hpet: %s is using irq %#x aka %d for MSI\n",
> +                        dev->name, dev->irq, dev->irq);
> +
>         return 0;
>  }
> 
> the change should be in hpet_setup_irq instead of hpet_late_init
> 
> the patch can be applied to tip/master cleanly.

ok, figure it out, the problem was that your change depended on 
tip/timers/hpet-percpu.

sorted it out.

	Ingo

Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Rolf Eike Beer]

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

Yinghai Lu wrote:
> v2: fix hpet compiling

Are you sure you sent the right patch? It only adds some printk()'s and 
unrelated newlines.

Eike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Bjorn Helgaas]

On Thursday 25 September 2008 12:13:43 am Yinghai Lu wrote:
> v2: fix hpet compiling
> 
> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
> ---
>  arch/x86/kernel/hpet.c    |    3 +++
>  arch/x86/kernel/io_apic.c |    7 +++++++
>  2 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
> index 422c577..686505a 100644
> --- a/arch/x86/kernel/hpet.c
> +++ b/arch/x86/kernel/hpet.c
> @@ -467,6 +467,9 @@ static int hpet_setup_irq(struct hpet_dev *dev)
>  	irq_set_affinity(dev->irq, cpumask_of_cpu(dev->cpu));
>  	enable_irq(dev->irq);
>  
> +	printk(KERN_DEBUG "hpet: %s is using irq %#x aka %d for MSI\n",
> +			 dev->name, dev->irq, dev->irq);
> +

Why do we want to print the irq as hex?  Do we do that anywhere else?
I think we should pick one format and stick with it, and I think
decimal is the logical choice because it's the most common.

Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Yinghai Lu]

On Thu, Sep 25, 2008 at 8:00 AM, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> On Thursday 25 September 2008 12:13:43 am Yinghai Lu wrote:
>> v2: fix hpet compiling
>>
>> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
>> ---
>>  arch/x86/kernel/hpet.c    |    3 +++
>>  arch/x86/kernel/io_apic.c |    7 +++++++
>>  2 files changed, 10 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
>> index 422c577..686505a 100644
>> --- a/arch/x86/kernel/hpet.c
>> +++ b/arch/x86/kernel/hpet.c
>> @@ -467,6 +467,9 @@ static int hpet_setup_irq(struct hpet_dev *dev)
>>       irq_set_affinity(dev->irq, cpumask_of_cpu(dev->cpu));
>>       enable_irq(dev->irq);
>>
>> +     printk(KERN_DEBUG "hpet: %s is using irq %#x aka %d for MSI\n",
>> +                      dev->name, dev->irq, dev->irq);
>> +
>
> Why do we want to print the irq as hex?  Do we do that anywhere else?
> I think we should pick one format and stick with it, and I think
> decimal is the logical choice because it's the most common.

when sparseirq is enabled, irq for msi will be bus_nr/dev/func + 12bits.
so show it as hex is more straight. but we can not use hex in
/proc/interrupts --ABI want decimal.

just try to print out...in log, so user could get some idea that who
is using it...

YH

Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Bjorn Helgaas]

On Thursday 25 September 2008 11:07:17 am Yinghai Lu wrote:
> On Thu, Sep 25, 2008 at 8:00 AM, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> > On Thursday 25 September 2008 12:13:43 am Yinghai Lu wrote:
> >> v2: fix hpet compiling
> >>
> >> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
> >> ---
> >>  arch/x86/kernel/hpet.c    |    3 +++
> >>  arch/x86/kernel/io_apic.c |    7 +++++++
> >>  2 files changed, 10 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
> >> index 422c577..686505a 100644
> >> --- a/arch/x86/kernel/hpet.c
> >> +++ b/arch/x86/kernel/hpet.c
> >> @@ -467,6 +467,9 @@ static int hpet_setup_irq(struct hpet_dev *dev)
> >>       irq_set_affinity(dev->irq, cpumask_of_cpu(dev->cpu));
> >>       enable_irq(dev->irq);
> >>
> >> +     printk(KERN_DEBUG "hpet: %s is using irq %#x aka %d for MSI\n",
> >> +                      dev->name, dev->irq, dev->irq);
> >> +
> >
> > Why do we want to print the irq as hex?  Do we do that anywhere else?
> > I think we should pick one format and stick with it, and I think
> > decimal is the logical choice because it's the most common.
> 
> when sparseirq is enabled, irq for msi will be bus_nr/dev/func + 12bits.
> so show it as hex is more straight. but we can not use hex in
> /proc/interrupts --ABI want decimal.
> 
> just try to print out...in log, so user could get some idea that who
> is using it...

I think it'd be better to just print the MSI IRQ number in decimal
using a dev_printk().  Then the connection is obvious and we don't
need to make everything ugly by having IRQs in both decimal and hex.

I know it's a nuisance to make hpet use dev_printk because it's
pretty muddled as far as getting a struct device.  But I'd rather
fix that than add confusion like this.

Bjorn

Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Ingo Molnar]

* Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:

> On Thursday 25 September 2008 11:07:17 am Yinghai Lu wrote:
> > On Thu, Sep 25, 2008 at 8:00 AM, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> > > On Thursday 25 September 2008 12:13:43 am Yinghai Lu wrote:
> > >> v2: fix hpet compiling
> > >>
> > >> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
> > >> ---
> > >>  arch/x86/kernel/hpet.c    |    3 +++
> > >>  arch/x86/kernel/io_apic.c |    7 +++++++
> > >>  2 files changed, 10 insertions(+), 0 deletions(-)
> > >>
> > >> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
> > >> index 422c577..686505a 100644
> > >> --- a/arch/x86/kernel/hpet.c
> > >> +++ b/arch/x86/kernel/hpet.c
> > >> @@ -467,6 +467,9 @@ static int hpet_setup_irq(struct hpet_dev *dev)
> > >>       irq_set_affinity(dev->irq, cpumask_of_cpu(dev->cpu));
> > >>       enable_irq(dev->irq);
> > >>
> > >> +     printk(KERN_DEBUG "hpet: %s is using irq %#x aka %d for MSI\n",
> > >> +                      dev->name, dev->irq, dev->irq);
> > >> +
> > >
> > > Why do we want to print the irq as hex?  Do we do that anywhere else?
> > > I think we should pick one format and stick with it, and I think
> > > decimal is the logical choice because it's the most common.
> > 
> > when sparseirq is enabled, irq for msi will be bus_nr/dev/func + 12bits.
> > so show it as hex is more straight. but we can not use hex in
> > /proc/interrupts --ABI want decimal.
> > 
> > just try to print out...in log, so user could get some idea that who
> > is using it...
> 
> I think it'd be better to just print the MSI IRQ number in decimal
> using a dev_printk().  Then the connection is obvious and we don't
> need to make everything ugly by having IRQs in both decimal and hex.
> 
> I know it's a nuisance to make hpet use dev_printk because it's
> pretty muddled as far as getting a struct device.  But I'd rather
> fix that than add confusion like this.

incidentally, in tip/timers/hpet-percpu [ new feature tree: MSI HPETs 
with per-CPU clockevents ] we have grown a struct device in that place, 
so it was easy :)

	Ingo

Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Cyrill Gorcunov]

[Ingo Molnar - Sat, Sep 27, 2008 at 08:53:06PM +0200]
|
...

A bit offtopic...well...completely offtopic I would say :)

Ingo maybe you have any PCI specs? I've asked several people
for this. Peter adviced to ask HW vendors but I don't have
friends who has access to a such docs. Evgeniy Polyakov
promised to ask someone but I think there will not be success
too :(. I'll ask Maciej too later since now he seems to be
quite busy.
 
		- Cyrill -

Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Jesse Barnes]

On Saturday, September 27, 2008 12:02 pm Cyrill Gorcunov wrote:
> [Ingo Molnar - Sat, Sep 27, 2008 at 08:53:06PM +0200]
>
> ...
>
> A bit offtopic...well...completely offtopic I would say :)
>
> Ingo maybe you have any PCI specs? I've asked several people
> for this. Peter adviced to ask HW vendors but I don't have
> friends who has access to a such docs. Evgeniy Polyakov
> promised to ask someone but I think there will not be success
> too :(. I'll ask Maciej too later since now he seems to be
> quite busy.

I think if you use google you can find the PCI spec in pdf form (search for 
pci pdf probably).  The MindShare books are also quite good, and cover PCI, 
PCI-X, and PCI Express in great detail (far more readable than the spec too).

-- 
Jesse Barnes, Intel Open Source Technology Center

Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Cyrill Gorcunov]

[Jesse Barnes - Mon, Sep 29, 2008 at 10:05:02AM -0700]
| On Saturday, September 27, 2008 12:02 pm Cyrill Gorcunov wrote:
| > [Ingo Molnar - Sat, Sep 27, 2008 at 08:53:06PM +0200]
| >
| > ...
| >
| > A bit offtopic...well...completely offtopic I would say :)
| >
| > Ingo maybe you have any PCI specs? I've asked several people
| > for this. Peter adviced to ask HW vendors but I don't have
| > friends who has access to a such docs. Evgeniy Polyakov
| > promised to ask someone but I think there will not be success
| > too :(. I'll ask Maciej too later since now he seems to be
| > quite busy.
| 
| I think if you use google you can find the PCI spec in pdf form (search for 
| pci pdf probably).  The MindShare books are also quite good, and cover PCI, 
| PCI-X, and PCI Express in great detail (far more readable than the spec too).
| 
| -- 
| Jesse Barnes, Intel Open Source Technology Center
| 

Thanks for reply, Jesse! Of course I could use google. But actually
the only think I found is version 2.2 (which is a bit old). Will take
a look if I could buy this book (not sure if it may be done here). PCI
membership is quite expencive for me that is why I was asking for this
documents in private mails I sent before. I don't like to behave like
that but just had to.

		- Cyrill -

Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Grant Grundler]

On Mon, Sep 29, 2008 at 09:29:28PM +0400, Cyrill Gorcunov wrote:
> [Jesse Barnes - Mon, Sep 29, 2008 at 10:05:02AM -0700]
> | On Saturday, September 27, 2008 12:02 pm Cyrill Gorcunov wrote:
> | > [Ingo Molnar - Sat, Sep 27, 2008 at 08:53:06PM +0200]
> | >
> | > ...
> | >
> | > A bit offtopic...well...completely offtopic I would say :)
> | >
> | > Ingo maybe you have any PCI specs? I've asked several people
> | > for this. Peter adviced to ask HW vendors but I don't have
> | > friends who has access to a such docs. Evgeniy Polyakov
> | > promised to ask someone but I think there will not be success
> | > too :(. I'll ask Maciej too later since now he seems to be
> | > quite busy.
> | 
> | I think if you use google you can find the PCI spec in pdf form (search for 
> | pci pdf probably).

Not probably. You will find them that way.

It is illegal for anyone to redistribute PCISIG copyrighted documents.
That hasn't stopped it from happening. I've pointed this out in the past
(and got a polite "please don't point that out again publicly").
I'm glad Jesse did instead. :)

>   The MindShare books are also quite good, and cover PCI, 
> | PCI-X, and PCI Express in great detail (far more readable than the spec too).

+1

grant

> | 
> | -- 
> | Jesse Barnes, Intel Open Source Technology Center
> | 
> 
> Thanks for reply, Jesse! Of course I could use google. But actually
> the only think I found is version 2.2 (which is a bit old). Will take
> a look if I could buy this book (not sure if it may be done here). PCI
> membership is quite expencive for me that is why I was asking for this
> documents in private mails I sent before. I don't like to behave like
> that but just had to.
> 
> 		- Cyrill -
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Cyrill Gorcunov]

On Mon, Sep 29, 2008 at 11:57 PM, Grant Grundler
<grundler@parisc-linux.org> wrote:
> On Mon, Sep 29, 2008 at 09:29:28PM +0400, Cyrill Gorcunov wrote:
>> [Jesse Barnes - Mon, Sep 29, 2008 at 10:05:02AM -0700]
>> | On Saturday, September 27, 2008 12:02 pm Cyrill Gorcunov wrote:
>> | > [Ingo Molnar - Sat, Sep 27, 2008 at 08:53:06PM +0200]
>> | >
>> | > ...
>> | >
>> | > A bit offtopic...well...completely offtopic I would say :)
>> | >
>> | > Ingo maybe you have any PCI specs? I've asked several people
>> | > for this. Peter adviced to ask HW vendors but I don't have
>> | > friends who has access to a such docs. Evgeniy Polyakov
>> | > promised to ask someone but I think there will not be success
>> | > too :(. I'll ask Maciej too later since now he seems to be
>> | > quite busy.
>> |
>> | I think if you use google you can find the PCI spec in pdf form (search for
>> | pci pdf probably).
>
> Not probably. You will find them that way.
>
> It is illegal for anyone to redistribute PCISIG copyrighted documents.
> That hasn't stopped it from happening. I've pointed this out in the past
> (and got a polite "please don't point that out again publicly").
> I'm glad Jesse did instead. :)
>
>>   The MindShare books are also quite good, and cover PCI,
>> | PCI-X, and PCI Express in great detail (far more readable than the spec too).
>
> +1
>
> grant
>
>> |
>> | --
>> | Jesse Barnes, Intel Open Source Technology Center
>> |
>>
>> Thanks for reply, Jesse! Of course I could use google. But actually
>> the only think I found is version 2.2 (which is a bit old). Will take
>> a look if I could buy this book (not sure if it may be done here). PCI
>> membership is quite expencive for me that is why I was asking for this
>> documents in private mails I sent before. I don't like to behave like
>> that but just had to.
>>
>>               - Cyrill -

Yes, the only acceptable solution is to buy one of these books - I've found
one in a local online shop. So I have no rights to ask such a question neither
I should. Actually it's a good example of _bad_ behaviour absolutely non-
acceptable in LKML!!! My apologizes!

RE: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Pallipadi, Venkatesh]

Doesn't look like this patch is doing anything with respect to "hpet compiling".
It is just adding some debug prints. I guess we need a better patch description.

Thanks,
Venki

>-----Original Message-----
>From: linux-kernel-owner@vger.kernel.org
>[mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Yinghai Lu
>Sent: Wednesday, September 24, 2008 11:14 PM
>To: Jesse Barnes; Len Brown; Ingo Molnar; Thomas Gleixner; H.
>Peter Anvin; Andrew Morton
>Cc: linux-kernel@vger.kernel.org; linux-pci@vger.kernel.org;
>linux-acpi@vger.kernel.org; Yinghai Lu
>Subject: [PATCH 7/7] x86: print out irq nr for msi/ht -v2
>
>v2: fix hpet compiling
>
>Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>


Doesn't look like the patch below is doing anything with respect to "hpet compiling".
It is just adding some debug prints. I guess we need a different patch description.

Thanks,
Venki


>---
> arch/x86/kernel/hpet.c    |    3 +++
> arch/x86/kernel/io_apic.c |    7 +++++++
> 2 files changed, 10 insertions(+), 0 deletions(-)
>
>diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
>index 422c577..686505a 100644
>--- a/arch/x86/kernel/hpet.c
>+++ b/arch/x86/kernel/hpet.c
>@@ -467,6 +467,9 @@ static int hpet_setup_irq(struct hpet_dev *dev)
>        irq_set_affinity(dev->irq, cpumask_of_cpu(dev->cpu));
>        enable_irq(dev->irq);
>
>+       printk(KERN_DEBUG "hpet: %s is using irq %#x aka %d for MSI\n",
>+                        dev->name, dev->irq, dev->irq);
>+
>        return 0;
> }
>
>diff --git a/arch/x86/kernel/io_apic.c b/arch/x86/kernel/io_apic.c
>index 4cc9cb6..dc82397 100644
>--- a/arch/x86/kernel/io_apic.c
>+++ b/arch/x86/kernel/io_apic.c
>@@ -3355,6 +3355,9 @@ static int setup_msi_irq(struct pci_dev
>*dev, struct msi_desc *desc, int irq)
> #endif
>                set_irq_chip_and_handler_name(irq, &msi_chip,
>handle_edge_irq, "edge");
>
>+       printk(KERN_DEBUG "PCI: %s is using irq %#x aka %d for
>MSI/MSI-X\n",
>+                        pci_name(dev), irq, irq);
>+
>        return 0;
> }
>
>@@ -3587,6 +3590,7 @@ int arch_setup_hpet_msi(unsigned int irq)
>        hpet_msi_write(irq, &msg);
>        set_irq_chip_and_handler_name(irq, &hpet_msi_type,
>handle_edge_irq,
>                "edge");
>+
>        return 0;
> }
> #endif
>@@ -3683,6 +3687,9 @@ int arch_setup_ht_irq(unsigned int irq,
>struct pci_dev *dev)
>
>                set_irq_chip_and_handler_name(irq, &ht_irq_chip,
>                                              handle_edge_irq, "edge");
>+
>+               printk(KERN_DEBUG "PCI: %s is using irq %#x
>aka %d for HT\n",
>+                                pci_name(dev), irq, irq);
>        }
>        return err;
> }
>--
>1.5.6
>
>--
>To unsubscribe from this list: send the line "unsubscribe
>linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/
>