public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Richter <robert.richter@amd.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org,
	oprofile-list@lists.sourceforge.net,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] oprofile: Don't report Nehalem as core_2
Date: Thu, 25 Sep 2008 22:05:21 +0200	[thread overview]
Message-ID: <20080925200521.GJ23557@erda.amd.com> (raw)
In-Reply-To: <1219250433-25516-4-git-send-email-andi@firstfloor.org>

On 20.08.08 18:40:32, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> This essentially reverts Linus' earlier 4b9f12a3779c548b68bc9af7d94030868ad3aa1b
> commit. Nehalem is not core_2, so it shouldn't be reported as such.
> However with the earlier arch perfmon patch it will fall back to
> arch perfmon mode now, so there is no need to fake it as core_2.
> The only drawback is that Linus will need to patch the arch perfmon
> support into his oprofile binary now, but I think he can do that.
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

I will send this patch upstream together with the architectural
perfmon implementation and when the userland part is upstream.

-Robert

> ---
>  arch/x86/oprofile/nmi_int.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/oprofile/nmi_int.c b/arch/x86/oprofile/nmi_int.c
> index 6438c32..669a713 100644
> --- a/arch/x86/oprofile/nmi_int.c
> +++ b/arch/x86/oprofile/nmi_int.c
> @@ -418,9 +418,6 @@ static int __init ppro_init(char **cpu_type)
>  	case 15: case 23:
>  		*cpu_type = "i386/core_2";
>  		break;
> -	case 26:
> -		*cpu_type = "i386/core_2";
> -		break;
>  	default:
>  		/* Unknown */
>  		return 0;
> -- 
> 1.5.6
> 
> 

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com


  parent reply	other threads:[~2008-09-25 20:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-20 16:40 oprofile: Implement Intel architectural perfmon Andi Kleen
2008-08-20 16:40 ` [PATCH] oprofile: drop const in num counters field Andi Kleen
2008-08-20 16:40   ` [PATCH] oprofile: Implement Intel architectural perfmon support Andi Kleen
2008-08-20 16:40     ` [PATCH] oprofile: Don't report Nehalem as core_2 Andi Kleen
2008-08-20 16:40       ` [PATCH] oprofile: document undocumented oprofile.p4force argument Andi Kleen
2008-09-25 20:10         ` Robert Richter
2008-09-25 20:05       ` Robert Richter [this message]
2008-09-25 20:00     ` [PATCH] oprofile: Implement Intel architectural perfmon support Robert Richter
2008-09-26  0:44       ` Andi Kleen
2008-09-26  3:23         ` Robert Richter
2008-09-26 23:09           ` Andi Kleen
2008-09-28  7:33             ` Robert Richter
2008-09-25 19:32 ` oprofile: Implement Intel architectural perfmon Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080925200521.GJ23557@erda.amd.com \
    --to=robert.richter@amd.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oprofile-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox