From: Greg KH <greg@kroah.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Jiri Slaby <jirislaby@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] PM: use pm_op methods for device types
Date: Thu, 25 Sep 2008 15:06:35 -0700 [thread overview]
Message-ID: <20080925220635.GA12175@kroah.com> (raw)
In-Reply-To: <200809252327.03305.rjw@sisk.pl>
On Thu, Sep 25, 2008 at 11:27:02PM +0200, Rafael J. Wysocki wrote:
> On Thursday, 25 of September 2008, Alan Stern wrote:
> > This patch (as1141) adds code to use the device type's pm_op methods,
> > if they are defined. It fixes a regression in the USB PM code; the
> > various suspend and resume methods are defined in the device type
> > rather than in the bus, because USB devices have to be handled
> > differently from USB interfaces. Without the patch, those methods
> > never get called.
> >
> > The patch also fixes a couple of spelling errors.
>
> Hm, these changes are not needed in the current mainline, so there's a patch
> in -next that removes the code added by this patch.
>
> It might be better to find that patch and drop it instead, IMO.
I agree, I think we would have seen more bugs if mainline can't suspend
with a USB device attached, right?
confused,
greg k-h
next prev parent reply other threads:[~2008-09-25 22:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 14:00 hda_intel (sigmatel) defunct in mmotm 2008-09-13-03-09 Jiri Slaby
2008-09-15 14:16 ` Matthew Ranostay
2008-09-16 14:43 ` Matthew Ranostay
2008-09-17 8:58 ` Jiri Slaby
2008-09-17 14:09 ` Matthew Ranostay
2008-09-24 9:42 ` Jiri Slaby
2008-09-17 16:46 ` suspend (uhci_hcd) " Jiri Slaby
2008-09-18 21:14 ` Alan Stern
2008-09-24 10:55 ` Jiri Slaby
2008-09-24 14:49 ` Alan Stern
2008-09-24 16:04 ` Jiri Slaby
2008-09-24 16:38 ` Alan Stern
2008-09-24 18:14 ` Greg KH
2008-09-24 18:19 ` Jiri Slaby
2008-09-24 18:54 ` Jiri Slaby
2008-09-24 21:29 ` Alan Stern
2008-09-25 20:51 ` Jiri Slaby
2008-09-25 21:07 ` [PATCH] PM: use pm_op methods for device types Alan Stern
2008-09-25 21:27 ` Rafael J. Wysocki
2008-09-25 22:06 ` Greg KH [this message]
2008-09-26 13:56 ` Alan Stern
2008-09-26 17:59 ` Greg KH
2008-10-06 15:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080925220635.GA12175@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox