From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754433AbYIYWJk (ORCPT ); Thu, 25 Sep 2008 18:09:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753429AbYIYWJa (ORCPT ); Thu, 25 Sep 2008 18:09:30 -0400 Received: from [198.145.64.141] ([198.145.64.141]:35193 "EHLO coco.kroah.org" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753225AbYIYWJa (ORCPT ); Thu, 25 Sep 2008 18:09:30 -0400 Date: Thu, 25 Sep 2008 15:06:35 -0700 From: Greg KH To: "Rafael J. Wysocki" Cc: Alan Stern , Andrew Morton , Jiri Slaby , Linux Kernel Mailing List , Linux-pm mailing list , USB list Subject: Re: [PATCH] PM: use pm_op methods for device types Message-ID: <20080925220635.GA12175@kroah.com> References: <200809252327.03305.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200809252327.03305.rjw@sisk.pl> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 25, 2008 at 11:27:02PM +0200, Rafael J. Wysocki wrote: > On Thursday, 25 of September 2008, Alan Stern wrote: > > This patch (as1141) adds code to use the device type's pm_op methods, > > if they are defined. It fixes a regression in the USB PM code; the > > various suspend and resume methods are defined in the device type > > rather than in the bus, because USB devices have to be handled > > differently from USB interfaces. Without the patch, those methods > > never get called. > > > > The patch also fixes a couple of spelling errors. > > Hm, these changes are not needed in the current mainline, so there's a patch > in -next that removes the code added by this patch. > > It might be better to find that patch and drop it instead, IMO. I agree, I think we would have seen more bugs if mainline can't suspend with a USB device attached, right? confused, greg k-h