From: Matthew Wilcox <matthew@wil.cx>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: Jing Huang <huangj@brocade.com>,
James.Bottomley@hansenpartnership.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
rvadivel@brocade.com, srayas@brocade.com, vravindr@brocade.com
Subject: Re: [PATCH 1/6] bfa: Brocade BFA FC SCSI driver submission (2nd try)
Date: Fri, 26 Sep 2008 06:22:19 -0600 [thread overview]
Message-ID: <20080926122219.GV27204@parisc-linux.org> (raw)
In-Reply-To: <200809260841.39433.eike-kernel@sf-tec.de>
On Fri, Sep 26, 2008 at 08:41:31AM +0200, Rolf Eike Beer wrote:
> You should use pcim_enable_device(). This would help you by simplifying your
> error and release code as it keeps track of freeing a bunch of resources. See
> Documentation/driver-model/devres.txt.
I hate the devres stuff. It takes care of most things behind your back,
but is terribly complex code and makes bugs next to impossible to track
down. Don't add more users for it unless you really, really have to.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-09-26 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 0:54 [PATCH 1/6] bfa: Brocade BFA FC SCSI driver submission (2nd try) Jing Huang
2008-09-26 2:52 ` Greg KH
2008-09-26 4:19 ` [PATCH 1/6] bfa: Brocade BFA FC SCSI driver submission (2ndtry) Jing Huang
2008-09-26 4:44 ` Greg KH
2008-09-26 6:41 ` [PATCH 1/6] bfa: Brocade BFA FC SCSI driver submission (2nd try) Rolf Eike Beer
2008-09-26 12:22 ` Matthew Wilcox [this message]
2008-09-26 12:45 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080926122219.GV27204@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@hansenpartnership.com \
--cc=eike-kernel@sf-tec.de \
--cc=huangj@brocade.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rvadivel@brocade.com \
--cc=srayas@brocade.com \
--cc=vravindr@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox