Re: [PATCH 1/6] bfa: Brocade BFA FC SCSI driver submission (2nd try)

Matthew Wilcox
2008-09-26T12:22:47Z

On Fri, Sep 26, 2008 at 08:41:31AM +0200, Rolf Eike Beer wrote:
> You should use pcim_enable_device(). This would help you by simplifying your
> error and release code as it keeps track of freeing a bunch of resources. See
> Documentation/driver-model/devres.txt.

I hate the devres stuff. It takes care of most things behind your back,
but is terribly complex code and makes bugs next to impossible to track
down. Don't add more users for it unless you really, really have to.

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."