Re: [PATCH 1/6] bfa: Brocade BFA FC SCSI driver submission (2nd try)

Alan Cox
2008-09-26T12:48:24Z

On Fri, 26 Sep 2008 06:22:19 -0600
Matthew Wilcox <matthew@wil.cx> wrote:

> On Fri, Sep 26, 2008 at 08:41:31AM +0200, Rolf Eike Beer wrote:
> > You should use pcim_enable_device(). This would help you by simplifying your
> > error and release code as it keeps track of freeing a bunch of resources. See
> > Documentation/driver-model/devres.txt.
>
> I hate the devres stuff. It takes care of most things behind your back,
> but is terribly complex code and makes bugs next to impossible to track
> down. Don't add more users for it unless you really, really have to.

Each to his own. I find the devres code very useful, but then I spend an
inordinate amount of time trying to sort out messes caused by developers
forgetting to free resources.

Using devres is a very good way to avoid having strange half tested paths
and leaks in your code, and if Matthew doesn't like the complexity of
devres (its not that complex IMHO) then he can tidy up the
implementation ;)

Alan