Re: [TOMOYO #9 (2.6.27-rc7-mm1) 1/6] LSM adapter functions.

Serge E. Hallyn
2008-09-26T13:04:50Z

Quoting Kentaro Takeda (takedakn@nttdata.co.jp):
> Serge E. Hallyn wrote:
> > > So IMO there is some major badness here in the form of copying all of
> > > those functions out of fs/namei.c. I think we need to discuss
> > > case-by-case whether using the functions is appropriate (and hence
> > > they should be made non-static in fs/namei.c), or whether the intended
> > > goal should be met some other way. For instance:
> Indeed.
>
> To perform DAC before MAC, cloning DAC code (like this patch) or some
> modifications against existing kernel code (such as non-static
> may_open()) are needed.
>
> This posting is the result of our intention that all changes should
> be within security/* . We are now aiming TOMOYO Linux to be merged
> without messing up the existing kernel code. (Also we put the code of
> singly linked list TOMOYO Linux uses not in include/linux/list.h but
> in security/tomoyo/common.h to avoid recomplilation.)
>
> We are ready to remove DAC code in TOMOYO Linux LSM module for now.
> (But DAC should be performed before MAC, it's our future work.) Since
> DAC is performed after security_path_*() hooks, this approach has no
> impact to the semantics of TOMOYO Linux. Is it preferable?

I see. Good point.

Unfortunately I think that is a shortcoming in the security_path_*
patchset. Unfortunate bc that is going to be a pain to work out.

But I do think it needs to be worked out in the core code, not in
Tomoyo (and each lsm using security_path_*). So for starters,
both vfs_mknod and vfs_create do may_create, so just pull that
into the callers. Now Al or Christoph may yell NO due to the
intended layering (which i'm not clear on), in which case the
solution will be tougher.

> > > likewise... (except in the case of fifo/sock, devcgroup should not be
> > > consulted as I'm not sure it'll handle that properly - have you tested
> > > tis with the device cgroup enabled?)
> Not tested yet... But I don't think problem occurs.
>
> Regards,