Re: [patch 2/6] kmsg: tagged device messages.

[Greg KH <gregkh@suse.de>]

On Thu, Sep 25, 2008 at 06:28:29PM +0200, Martin Schwidefsky wrote:
> From: Martin Schwidefsky <schwidefsky@de.ibm.com>
> From: Michael Holzheu <holzheu@de.ibm.com>
> 
> Add CONFIG_MSG_IDS support to the dev_xxx printk family. The message
> tag for a device printk consists of the driver name and the 24 bit
> hash over the message text. The hash is included in the printed line
> if the KMSG_COMPONENT macro is defined and CONFIG_MSG_IDS=y. For
> source files that do not define KMSG_COMPONENT or CONFIG_MSG_IDS=n
> the dev_xxx printks use the old-style format. 
> 
> To make it possible for a script to extract the correct message tag
> for the dev_xxx printks the KMSG_COMPONENT and the driver name need to
> be identical for all dev_xxx printks in a source file. If a source file
> is supposed to be converted to use message tags and there are dev_xxx
> printks with driver names different to KMSG_COMPONENT these dev_xxx
> printks need to be replaced with kmsg_xxx printks. In praxis this
> should not be a problem since there are very few dev_xxx printks outside
> of driver code.
> 
> In addition to the KMSG_COMPONENT changes in include/linux/device.h the
> dev_xxx macros with variable arguments are converted from the gcc specific
> '## arg' to the C99 variant '##__VA_ARGS__'.
> 
> Signed-off-by: Michael Holzheu <holzheu@de.ibm.com>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

Nice, thanks for reworking this.  Feel free to add:
	Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
here.

Note that you will get some merge errors with -next in device.h due to
the dynamic debug printk work that is in my tree and in -next as well.
But it should be simple to resolve.

thanks,

greg k-h