public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joerg.roedel@amd.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
	linux-kernel@vger.kernel.org, fujita.tomonori@lab.ntt.co.jp
Subject: Re: [PATCH 3/3] x86/iommu: use __GFP_ZERO instead of memset for GART
Date: Sun, 28 Sep 2008 21:34:36 +0200	[thread overview]
Message-ID: <20080928193436.GA8386@amd.com> (raw)
In-Reply-To: <20080927181855.GA11147@elte.hu>

On Sat, Sep 27, 2008 at 08:18:55PM +0200, Ingo Molnar wrote:
> 
> another thing:
> 
> How hard would it be to add an CONFIG_IOMMU_DEBUG option that forces as 
> many DMA requests to go via the IOMMU as possible?
> 
> This slows things down of course so it's only for debugging - but it 
> also makes sure that we utilize the IOMMU code to the maximum - which is 
> not normally the case.
> 
> Would be nice to have it .config driven (default-disabled), so that 
> -tip's randconfig testing can stumble upon it every now and then. I've 
> got GART test-systems - this way we could find certain types of IOMMU 
> breakages sooner.

For AMD IOMMU I disabled the round-robin allocator to stress-test the
code. This means that the address allocation bitmap is always traversed
from the first bit. In consequence the TLB flushing is stressed a lot
(both in hardware and software) because the same DMA addresses are used
again and again. For testing I hardcoded it into the driver but I can
also make it depend on CONFIG_IOMMU_DEBUG.

Joerg

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy


  parent reply	other threads:[~2008-09-28 19:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-25 10:13 [PATCH 0/3] some small GART cleanups Joerg Roedel
2008-09-25 10:13 ` [PATCH 1/3] x86/iommu: make GART driver checkpatch clean Joerg Roedel
2008-09-25 10:13 ` [PATCH 2/3] x86/iommu: convert GART need_flush to bool Joerg Roedel
2008-09-25 10:13 ` [PATCH 3/3] x86/iommu: use __GFP_ZERO instead of memset for GART Joerg Roedel
2008-09-25 10:20   ` Ingo Molnar
2008-09-25 10:42     ` Joerg Roedel
2008-09-27 18:14       ` Ingo Molnar
2008-09-27 18:18         ` Ingo Molnar
2008-09-28 18:06           ` FUJITA Tomonori
2008-09-28 19:34           ` Joerg Roedel [this message]
2008-09-29  8:56             ` Ingo Molnar
2008-09-29 14:11               ` FUJITA Tomonori
2008-09-30 11:03                 ` Ingo Molnar
2008-09-30 20:53                   ` H. Peter Anvin
2008-09-28 14:48         ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080928193436.GA8386@amd.com \
    --to=joerg.roedel@amd.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox