public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Pekka Paalanen <pq@iki.fi>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	rostedt@goodmis.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -tip 2/3] Tracing/ftrace: Adapt mmiotrace to the new type of print_line
Date: Mon, 29 Sep 2008 11:02:31 +0200	[thread overview]
Message-ID: <20080929090231.GD2190@elte.hu> (raw)
In-Reply-To: <20080928192909.30e0f5dd@daedalus.pq.iki.fi>


* Pekka Paalanen <pq@iki.fi> wrote:

> > +		return TRACE_TYPE_HANDLED;
> >  	}
> >  }
> 
> Otherwise, very good.
> 
> As Ingo reverted the two earlier patches, you need to rebase these 
> two. I'd like to see these in upstream. Let's handle the pipe closing 
> bug in a different patch.

good. Frederic, please just resubmit all fixes you have against 
tip/master, with Pekka's Acked-by added. You can submit Pekka's patch as 
well, so that it's a coherent series. The customary way for that is to 
add in a From line as the first line of the changelog:

 From: Pekka Paalanen <pq@iki.fi>

and add your signoff to the end of the changelog. This way Git will show 
Pekka as the author and the path of the patch is well understood.

Thanks,

	Ingo

  reply	other threads:[~2008-09-29  9:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-26 15:44 [PATCH -tip 2/3] Tracing/ftrace: Adapt mmiotrace to the new type of print_line Frederic Weisbecker
2008-09-26 21:21 ` Pekka Paalanen
2008-09-27 12:17   ` Frédéric Weisbecker
2008-09-27 16:19     ` Ingo Molnar
2008-09-28 17:12     ` trace_pipe tentative fix (Re: [PATCH -tip 2/3] Tracing/ftrace: Adapt mmiotrace to the new type of print_line) Pekka Paalanen
2008-09-28 18:58       ` trace_pipe tentative fix Pekka Paalanen
2008-09-29 17:49         ` Frédéric Weisbecker
2008-09-29  9:20       ` trace_pipe tentative fix (Re: [PATCH -tip 2/3] Tracing/ftrace: Adapt mmiotrace to the new type of print_line) Frédéric Weisbecker
2008-09-28 16:29 ` [PATCH -tip 2/3] Tracing/ftrace: Adapt mmiotrace to the new type of print_line Pekka Paalanen
2008-09-29  9:02   ` Ingo Molnar [this message]
2008-09-29  9:28     ` Frédéric Weisbecker
2008-09-29  9:47       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080929090231.GD2190@elte.hu \
    --to=mingo@elte.hu \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pq@iki.fi \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox