Re: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, barnr) function

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Monday, September 29, 2008 10:02 am Rolf Eike Beer wrote:
> Arjan van de Ven wrote:
> > The patch below introduces a pci_ioremap() function that should make it
> > easier for driver authors to do the right thing for the simple, common
> > case.
> >
> > There's also 18 patches that introduce users of this; to reduce lkml
> > noise I've only stuck them in a git tree at
> > git://git.kernel.org/pub/scm/linux/kernel/git/arjan/linux-2.6-pci_ioremap
> >.g it
> > (http://git.kernel.org/?p=linux/kernel/git/arjan/linux-2.6-pci_ioremap.gi
> >t; a=summary)
> >
> >
> > From fef1dd836bc7dc07962a0ae4019af9efd373c76f Mon Sep 17 00:00:00 2001
> > From: Arjan van de Ven <arjan@linux.intel.com>
> > Date: Fri, 26 Sep 2008 16:34:52 -0700
> > Subject: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, barnr)
> > function
> >
> > A common thing in many PCI drivers is to ioremap() an entire bar.
> > This is a slightly fragile thing right now, needing both an address and a
> > size, and many driver writers do.. various things there.
> >
> > This patch introduces an pci_ioremap() function taking just a PCI device
> > struct and the bar number as arguments, and figures this all out itself,
> > in one place. In addition, we can add various sanity checks to this
> > function (the patch already checks to make sure that the bar in question
> > really is a MEM bar; few to no drivers do that sort of thing).
>
> This is the same like pci_iomap(pdev, number, 0), no?

Yeah... Looks like that function isn't that widely used though.  Is the maxlen 
param really needed?  Looks like the drivers that use it often pass 0 or the 
BAR length anyway, and Arjan converted existing drivers too, which is where 
the real work is.

Jesse