From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752255AbYI2Oby (ORCPT ); Mon, 29 Sep 2008 10:31:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751328AbYI2Obq (ORCPT ); Mon, 29 Sep 2008 10:31:46 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:49529 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751367AbYI2Obp (ORCPT ); Mon, 29 Sep 2008 10:31:45 -0400 Date: Mon, 29 Sep 2008 09:31:44 -0500 From: Russ Anderson To: Huang Ying Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@linutronix.de, "H. Peter Anvin" , Jack Steiner , Russ Anderson Subject: Re: [PATCH 2/4] x86: Add UV bios call infrastructure v2 Message-ID: <20080929143144.GA116670@sgi.com> Reply-To: Russ Anderson References: <20080926200242.GC138671@sgi.com> <1222478495.28661.19.camel@yhuang-dev.sh.intel.com> <20080928150106.GA204845@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080928150106.GA204845@sgi.com> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 28, 2008 at 10:01:07AM -0500, Russ Anderson wrote: > On Sat, Sep 27, 2008 at 09:21:35AM +0800, Huang Ying wrote: > > On Fri, 2008-09-26 at 15:02 -0500, Russ Anderson wrote: > > > Index: linux/include/asm-x86/efi.h > > > =================================================================== > > > --- linux.orig/include/asm-x86/efi.h 2008-09-26 14:13:24.000000000 -0500 > > > +++ linux/include/asm-x86/efi.h 2008-09-26 14:13:36.000000000 -0500 > > > @@ -49,6 +49,20 @@ extern u64 efi_call5(void *fp, u64 arg1, > > > extern u64 efi_call6(void *fp, u64 arg1, u64 arg2, u64 arg3, > > > u64 arg4, u64 arg5, u64 arg6); > > > > > > + > > > +#ifndef CONFIG_EFI > > > +/* > > > + * IF EFI is not configured, have the EFI calls return -ENOSYS. > > > + */ > > > +#define efi_call0(_f) (-ENOSYS) > > > +#define efi_call1(_f, _a1) (-ENOSYS) > > > +#define efi_call2(_f, _a1, _a2) (-ENOSYS) > > > +#define efi_call3(_f, _a1, _a2, _a3) (-ENOSYS) > > > +#define efi_call4(_f, _a1, _a2, _a3, _a4) (-ENOSYS) > > > +#define efi_call5(_f, _a1, _a2, _a3, _a4, _a5) (-ENOSYS) > > > +#define efi_call6(_f, _a1, _a2, _a3, _a4, _a5, _a6) (-ENOSYS) > > > +#endif /* CONFIG_EFI */ > > > + > > > #define efi_call_phys0(f) \ > > > efi_call0((void *)(f)) > > > #define efi_call_phys1(f, a1) \ > > > > efi_call_virt and efi_call_phys is the API instead of efi_call. > > #define efi_call_virt6(f, a1, a2, a3, a4, a5, a6) \ > efi_call6((void *)(efi.systab->runtime->f), (u64)(a1), (u64)(a2), \ > (u64)(a3), (u64)(a4), (u64)(a5), (u64)(a6)) > > efi_call_virt6() uses efi.systab->runtime->f. > My call needs to use uv_systab, not efi.systab. After thinking about this, if a new runtime call was added to efi_runtime_services_t, then the existing efi_call_virt could be used. This would remove the need to create uv_systab. I'll post a patch shortly. -- Russ Anderson, OS RAS/Partitioning Project Lead SGI - Silicon Graphics Inc rja@sgi.com