From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753846AbYI2PJ0 (ORCPT ); Mon, 29 Sep 2008 11:09:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751328AbYI2PJS (ORCPT ); Mon, 29 Sep 2008 11:09:18 -0400 Received: from tomts20.bellnexxia.net ([209.226.175.74]:53826 "EHLO tomts20-srv.bellnexxia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752061AbYI2PJR (ORCPT ); Mon, 29 Sep 2008 11:09:17 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgUFAL+L4EhMQWq+/2dsb2JhbACBYrowgWc Date: Mon, 29 Sep 2008 11:09:15 -0400 From: Mathieu Desnoyers To: Ingo Molnar Cc: Lai Jiangshan , Andrew Morton , "Paul E. McKenney" , Linux Kernel Mailing List , Steven Rostedt , Peter Zijlstra , Rusty Russell , "Frank Ch. Eigler" Subject: [PATCH] Markers : probe example fix teardown Message-ID: <20080929150915.GF11245@Krystal> References: <48E08B05.7030802@cn.fujitsu.com> <20080929082722.GB18663@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <20080929082722.GB18663@elte.hu> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.6.21.3-grsec (i686) X-Uptime: 11:08:07 up 116 days, 19:48, 9 users, load average: 0.82, 0.76, 0.53 User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Need a marker_synchronize_unregister() before the end of exit() to make sure every probe callers have exited the non preemptible section and thus are not executing the probe code anymore. Signed-off-by: Mathieu Desnoyers CC: Ingo Molnar CC: Rusty Russell CC: akpm@linux-foundation.org CC: "Frank Ch. Eigler" --- samples/markers/probe-example.c | 1 + 1 file changed, 1 insertion(+) Index: linux-2.6-lttng/samples/markers/probe-example.c =================================================================== --- linux-2.6-lttng.orig/samples/markers/probe-example.c 2008-07-31 09:11:13.000000000 -0400 +++ linux-2.6-lttng/samples/markers/probe-example.c 2008-07-31 09:18:54.000000000 -0400 @@ -81,6 +81,7 @@ static void __exit probe_fini(void) probe_array[i].probe_func, &probe_array[i]); printk(KERN_INFO "Number of event b : %u\n", atomic_read(&eventb_count)); + marker_synchronize_unregister(); } module_init(probe_init); -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68