From: Andi Kleen <andi@firstfloor.org>
To: dean gaudet <odo@google.com>
Cc: Andi Kleen <andi@firstfloor.org>, Pardo <pardo@google.com>,
linux-kernel@vger.kernel.org, mbligh@google.com,
briangrant@google.com, nil@google.com, jyasskin@google.com
Subject: Re: Faster getcpu() and sched_getcpu()
Date: Tue, 30 Sep 2008 00:07:17 +0200 [thread overview]
Message-ID: <20080929220717.GU25711@one.firstfloor.org> (raw)
In-Reply-To: <48E14ECE.6080402@google.com>
On Mon, Sep 29, 2008 at 02:55:26PM -0700, dean gaudet wrote:
> Andi Kleen wrote:
> > On Mon, Sep 29, 2008 at 11:01:26AM -0700, Pardo wrote:
> >
> >>> [Maybe disable frame pointers for vsyscall.c and the vdso?]
> >>>
> >> IIRC, some vsyscall.c code needs them enabled, so Dean's earlier patch split
> >>
> >
> > I don't think it really needs it.
> >
> >
> >> vsyscall.c, creating a vsyscall_user.c for code which can run without them.
> >> Seem reasonable?
> >>
> >
> > Seems unnecessarily complicated.
> >
>
> i disagree that it's complicated to have two files, and disagree that
> it's unnecessary to have two files.
It's unnecessary to have frame pointer in the kernel functions I meant.
I agree with you that disabling redzone is needed for kernel code,
but without frame pointers (which are generally a bad idea for
performance and should not have been added to the 64bit port ever)
redzone is also not particularly expensive and it shouldn't be needed
to do anything complicated (like splitting files) just for the few
cycles.
-Andi
--
ak@linux.intel.com
prev parent reply other threads:[~2008-09-29 22:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <af8810200809111648n55e05ac9g286fcd498690432f@mail.gmail.com>
2008-09-23 19:09 ` Faster getcpu() and sched_getcpu() Pardo
2008-09-23 19:48 ` Fwd: " Pardo
2008-09-28 16:42 ` Andi Kleen
2008-09-29 7:27 ` dean gaudet
2008-09-29 14:54 ` Andi Kleen
2008-09-29 18:02 ` Pardo
[not found] ` <af8810200809291101r6f3208beua36a4b2d3b5713eb@mail.gmail.com>
2008-09-29 20:50 ` Andi Kleen
[not found] ` <48E14ECE.6080402@google.com>
2008-09-29 21:59 ` dean gaudet
2008-09-29 22:07 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080929220717.GU25711@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=briangrant@google.com \
--cc=jyasskin@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
--cc=nil@google.com \
--cc=odo@google.com \
--cc=pardo@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox