public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86: IOMMU setup failures should not be KERN_ERR
@ 2008-09-29 18:52 Adam Jackson
  2008-09-30  8:25 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Adam Jackson @ 2008-09-29 18:52 UTC (permalink / raw)
  To: linux-kernel; +Cc: Adam Jackson

The number of BIOSes that have an option to enable the IOMMU, or fix
anything about its configuration, is vanishingly small.  There's no good
reason to punish quiet boot for this.

Signed-off-by: Adam Jackson <ajax@redhat.com>
---
 arch/x86/kernel/aperture_64.c |    6 +++---
 include/asm-x86/gart.h        |    6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
index 44e2182..9a32b37 100644
--- a/arch/x86/kernel/aperture_64.c
+++ b/arch/x86/kernel/aperture_64.c
@@ -455,11 +455,11 @@ out:
 		   force_iommu ||
 		   valid_agp ||
 		   fallback_aper_force) {
-		printk(KERN_ERR
+		printk(KERN_INFO
 			"Your BIOS doesn't leave a aperture memory hole\n");
-		printk(KERN_ERR
+		printk(KERN_INFO
 			"Please enable the IOMMU option in the BIOS setup\n");
-		printk(KERN_ERR
+		printk(KERN_INFO
 			"This costs you %d MB of RAM\n",
 				32 << fallback_aper_order);
 
diff --git a/include/asm-x86/gart.h b/include/asm-x86/gart.h
index 3f62a83..583031c 100644
--- a/include/asm-x86/gart.h
+++ b/include/asm-x86/gart.h
@@ -52,15 +52,15 @@ static inline int aperture_valid(u64 aper_base, u32 aper_size, u32 min_size)
 		return 0;
 
 	if (aper_base + aper_size > 0x100000000ULL) {
-		printk(KERN_ERR "Aperture beyond 4GB. Ignoring.\n");
+		printk(KERN_INFO "Aperture beyond 4GB. Ignoring.\n");
 		return 0;
 	}
 	if (e820_any_mapped(aper_base, aper_base + aper_size, E820_RAM)) {
-		printk(KERN_ERR "Aperture pointing to e820 RAM. Ignoring.\n");
+		printk(KERN_INFO "Aperture pointing to e820 RAM. Ignoring.\n");
 		return 0;
 	}
 	if (aper_size < min_size) {
-		printk(KERN_ERR "Aperture too small (%d MB) than (%d MB)\n",
+		printk(KERN_INFO "Aperture too small (%d MB) than (%d MB)\n",
 				 aper_size>>20, min_size>>20);
 		return 0;
 	}
-- 
1.6.0.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86: IOMMU setup failures should not be KERN_ERR
  2008-09-29 18:52 [PATCH] x86: IOMMU setup failures should not be KERN_ERR Adam Jackson
@ 2008-09-30  8:25 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-09-30  8:25 UTC (permalink / raw)
  To: Adam Jackson; +Cc: linux-kernel, Thomas Gleixner, H. Peter Anvin


* Adam Jackson <ajax@redhat.com> wrote:

> The number of BIOSes that have an option to enable the IOMMU, or fix
> anything about its configuration, is vanishingly small.  There's no good
> reason to punish quiet boot for this.
> 
> Signed-off-by: Adam Jackson <ajax@redhat.com>
> ---
>  arch/x86/kernel/aperture_64.c |    6 +++---
>  include/asm-x86/gart.h        |    6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)

applied to tip/x86/debug, thanks Adam!

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-09-30  8:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-29 18:52 [PATCH] x86: IOMMU setup failures should not be KERN_ERR Adam Jackson
2008-09-30  8:25 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox