From: Ingo Molnar <mingo@elte.hu>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: linux-kernel@vger.kernel.org, sfr@canb.auug.org.au,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Yinghai Lu <yhlu.kernel@gmail.com>, Samuel Sieb <samuel@sieb.net>
Subject: Re: [PATCH] x86: enable CPUID on Cyrix cpus with CPUID disabled
Date: Tue, 30 Sep 2008 11:43:30 +0200 [thread overview]
Message-ID: <20080930094330.GA15607@elte.hu> (raw)
In-Reply-To: <20080929192407.1c31fe90.krzysztof.h1@poczta.fm>
* Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
>
> The macros setCx86_old() and getCx86_old() do not
> work as a comment says in the processor-cyrix.h.
>
> Use working inline functions instead to enable
> the CPUID instriction on Cyrix cpus.
>
> Tested on IBM 6x86MX cpu with disabled the
> CPUID instruction.
>
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> ---
>
> This patch is against the linux-next tree (20080819)
> as it contains the following patch:
>
> x86, cyrix: debug
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
>
> http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commit;h=026e2c05ef58ef413e2d52696f125d5ea1aa8bce
>
> The linux-2.6-tip tree has not the Ingo's patch so it
> does not require my patch.
>
> I am confused. Is the x86 detection code for Cyrix
> cpus is right in the linux-next or in the linux-2.6-tip?
> Should I prepare patches against the linux-2.6-tip
> or linux-next?
now that the bug is correctly understood and fixed, could you please
send a patch that cleans it all up and gets rid of the setCx86_old() /
setCx86() API distinction? I.e. revert commit 026e2c0 ("x86, cyrix:
debug"). Against tip/master please.
note that this was all done in connection to:
commit c6744955d0ec0cb485c28c51eeb7185e260f6172
Author: Samuel Sieb <samuel@sieb.net>
Date: Wed Aug 6 22:06:29 2008 -0700
x86: fix "kernel won't boot on a Cyrix MediaGXm (Geode)"
Ingo
next prev parent reply other threads:[~2008-09-30 9:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 17:24 [PATCH] x86: enable CPUID on Cyrix cpus with CPUID disabled Krzysztof Helt
2008-09-29 17:56 ` Yinghai Lu
2008-09-30 9:43 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-30 13:06 krzysztof.h1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080930094330.GA15607@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel@sieb.net \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox