public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Stefan Bader <stefan.bader@canonical.com>
Cc: linux-kernel@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: Reserve FIRST_DEVICE_VECTOR in used_vectors bitmap.
Date: Tue, 30 Sep 2008 11:51:49 +0200	[thread overview]
Message-ID: <20080930095149.GA7557@elte.hu> (raw)
In-Reply-To: <48E0DA7C.5010403@canonical.com>


> Someone from the community found out, that after repeatedly unloading 
> and loading a device driver that uses MSI IRQs, the system eventually 
> assigned the vector initially reserved for IRQ0 to the device driver.

> The reason for this is, that although IRQ0 is tied to the 
> FIRST_DEVICE_VECTOR when declaring the irq_vector table, the 
> corresponding bit in the used_vectors map is not set. So, if vectors 
> are released and assigned often enough, the vector will get assigned 
> to another interrupt. This happens more often with MSI interrupts as 
> those are exclusively using a vector.
>
> Fix this by setting the bit for the FIRST_DEVICE_VECTOR in the bitmap.

hi, the IO-APIC code got unified in the x86 tree for v2.6.28.

So could you please send the fix against tip/master:

  http://people.redhat.com/mingo/tip.git/README

Thanks,

	Ingo

  reply	other threads:[~2008-09-30  9:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-29 13:39 [PATCH] x86: Reserve FIRST_DEVICE_VECTOR in used_vectors bitmap Stefan Bader
2008-09-30  9:51 ` Ingo Molnar [this message]
2008-09-30 12:53   ` Stefan Bader
2008-10-02 12:14     ` Stefan Bader
2008-10-03  8:56       ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2008-10-10 20:01 Stefan Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080930095149.GA7557@elte.hu \
    --to=mingo@elte.hu \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefan.bader@canonical.com \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox