From: Frans Pop <elendil@planet.nl>
To: venkatesh.pallipadi@intel.com
Cc: Ingo Molnar <mingo@elte.hu>,
arjan@linux.intel.com, tglx@linutronix.de, hpa@zytor.com,
andi@firstfloor.org, linux-kernel@vger.kernel.org,
suresh.b.siddha@intel.com
Subject: Re: [patch 2/2] x86: Handle error returns in set_memory_*
Date: Tue, 30 Sep 2008 10:36:04 +0200 [thread overview]
Message-ID: <200809301036.05207.elendil@planet.nl> (raw)
In-Reply-To: <20080914141012.GA17727@elte.hu>
Ingo Molnar wrote:
> * Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> wrote:
>> Correctly handle the error returns from set_memory_*. We have to free
>> memtype on error return path.
>
> we should emit a kernel warning as well if any of those calls fail.
> Drivers should not be randomly poking on RAM ranges.
Has this comment from Ingo been addressed already?
> i'm also missing some background on this, could you please explain in a
> bit more detail about what errors there were triggered, and how they
> caused the display artifacts?
I would be interested in this as well.
As I mentioned before, I only tested with the first of the two patches
(as you asked me to) and that solved the artifacts for me. What's the
explanation behind that?
What is the relationship between the first and second patch?
Cheers,
FJP
next prev parent reply other threads:[~2008-09-30 8:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 0:00 [patch 0/2] PAT fix/optimization Venkatesh Pallipadi
2008-09-13 0:00 ` [patch 1/2] x86: track memtype for RAM in page struct Venkatesh Pallipadi
2008-09-13 17:03 ` Jeremy Fitzhardinge
2008-09-14 13:29 ` Ingo Molnar
2008-09-14 14:18 ` Jeremy Fitzhardinge
2008-09-14 14:22 ` Ingo Molnar
2008-09-23 21:46 ` Venki Pallipadi
2008-09-23 21:59 ` Christoph Lameter
2008-09-24 15:53 ` [patch 1/2] x86: track memtype for RAM in page struct - v3 Venki Pallipadi
2008-09-27 17:59 ` Ingo Molnar
2008-09-30 7:28 ` Nick Piggin
2008-09-30 11:21 ` Ingo Molnar
2008-09-30 21:14 ` Suresh Siddha
2008-10-01 9:29 ` Ingo Molnar
2008-10-02 2:27 ` Nick Piggin
2008-09-13 17:24 ` [patch 1/2] x86: track memtype for RAM in page struct Frans Pop
2008-09-14 14:12 ` Ingo Molnar
2008-09-23 21:48 ` Pallipadi, Venkatesh
2008-09-13 0:00 ` [patch 2/2] x86: Handle error returns in set_memory_* Venkatesh Pallipadi
2008-09-14 13:27 ` Ingo Molnar
2008-09-14 14:35 ` Frans Pop
2008-09-14 14:10 ` Ingo Molnar
2008-09-30 8:36 ` Frans Pop [this message]
2008-09-30 21:29 ` Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809301036.05207.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=andi@firstfloor.org \
--cc=arjan@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox