From: Ingo Molnar <mingo@elte.hu>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: joerg.roedel@amd.com, mingo@redhat.com, tglx@linutronix.de,
hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] x86/iommu: use __GFP_ZERO instead of memset for GART
Date: Tue, 30 Sep 2008 13:03:19 +0200 [thread overview]
Message-ID: <20080930110319.GA12529@elte.hu> (raw)
In-Reply-To: <20080929231116Q.fujita.tomonori@lab.ntt.co.jp>
* FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
> > yes - could you please make a new option for it,
> > CONFIG_IOMMU_DEBUG_FORCE=y or so - and cover all iommus that support
> > it?
>
> I'm not sure we are talking about the same thing. Surely, I and Joerg
> are talking different things.
>
> GART driver doesn't need to use the IOMMU hardware at all times. GART
> does a virtual mapping only when necessary (a device needs to handle
> an address that it can't access to). But as I wrote, if you use
> iommu=force, GART driver always use the IOMMU hardware.
yes - but iommu=force is not randconfig covered, hence it never gets
tested by -tip testing. So my suggestion was a really simple patch: a
new Kconfig entry that makes iommu=force default.
CONFIG_BOOTPARAM_IOMMU_FORCE=y would be the right name for it. (disabled
by default, of course)
> Other x86 IOMMU drivers always use the IOMMU hardware. Except for
> Intel VT-D, they manage free virtual I/O space in the round-robin
> manner with the bitmap algorithm to avoid frequent IOTLB flush. Joerg
> said he tested AMD IOMMU driver with the round-robin manner disabled
> so AMD IOMMU driver uses the same virtual I/O space with lots of IOTLB
> flush.
all i'm suggesting is to please expose existing debug capabilities in
the .config space, so that it can be tested in automated setups.
Ingo
next prev parent reply other threads:[~2008-09-30 11:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 10:13 [PATCH 0/3] some small GART cleanups Joerg Roedel
2008-09-25 10:13 ` [PATCH 1/3] x86/iommu: make GART driver checkpatch clean Joerg Roedel
2008-09-25 10:13 ` [PATCH 2/3] x86/iommu: convert GART need_flush to bool Joerg Roedel
2008-09-25 10:13 ` [PATCH 3/3] x86/iommu: use __GFP_ZERO instead of memset for GART Joerg Roedel
2008-09-25 10:20 ` Ingo Molnar
2008-09-25 10:42 ` Joerg Roedel
2008-09-27 18:14 ` Ingo Molnar
2008-09-27 18:18 ` Ingo Molnar
2008-09-28 18:06 ` FUJITA Tomonori
2008-09-28 19:34 ` Joerg Roedel
2008-09-29 8:56 ` Ingo Molnar
2008-09-29 14:11 ` FUJITA Tomonori
2008-09-30 11:03 ` Ingo Molnar [this message]
2008-09-30 20:53 ` H. Peter Anvin
2008-09-28 14:48 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080930110319.GA12529@elte.hu \
--to=mingo@elte.hu \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hpa@zytor.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox