Re: [RFC PATCH] LTTng relay buffer allocation, read, write

[Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>]

* Martin Bligh (mbligh@google.com) wrote:
> > You are actually using them to put redundant information that could be
> > encoded differently and thus save 4 bits per event records, more or less
> > what will be needed by most tracers (15 IDs, 1 reserved for an extended
> > ID field).
> 
> You have 15 event types that are useful with no data payload at all?
> 

I am not saying anything about the actual number of events with 0 bytes
payload I actually have in my own instrumentation, if this is what you
mean. I am just saying that it leaves this room available for such
events.

Even if there is a 32 bits payload associated with those events, the
fact that we can encode the event ID in the 32 bits header will bring
those events from 96 bits (due to 32 bits alignment) down to 64 bits.

> > So the fact that you use them does not mean they are really required,
> > and I don't think such duplicated information actually makes things more
> > solid. Maybe just more obscure ?
> 
> This is all over 1 bit of information, right? Since you need at least 1 for
> the timestamp stuff.

4 bits of information could be added to the 32-bits header if we allow
tracers to register their first 15 event IDs in those 4 bits.

But well... let's keep that for v2. ;)

Mathieu

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68