From: Ingo Molnar <mingo@elte.hu>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
linux-kernel@vger.kernel.org, Mike Travis <travis@sgi.com>,
Dave Jones <davej@redhat.com>
Subject: Re: [PATCH] x86: clean up speedctep-centrino and reduce cpumask_t usage
Date: Wed, 1 Oct 2008 08:44:01 +0200 [thread overview]
Message-ID: <20081001064401.GA31855@elte.hu> (raw)
In-Reply-To: <200810010901.55127.rusty@rustcorp.com.au>
* Rusty Russell <rusty@rustcorp.com.au> wrote:
> 1) The #ifdef CONFIG_HOTPLUG_CPU seems unnecessary these days.
> 2) The loop can simply skip over offline cpus, rather than creating a tmp mask.
> 3) set_mask is set to either a single cpu or all online cpus in a policy.
> Since it's just used for set_cpus_allowed(), any offline cpus in a policy
> don't matter, so we can just use cpumask_of_cpu() or the policy->cpus.
>
> Note: untested, since I don't have such a system.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
nice cleanup! (Dave Jones Cc:-ed)
maybe it's better to keep this in the cpumask_t series though, to not
complicate logistics?
> diff -r dc205c205c8a arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c
> --- a/arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c Sun Sep 28 18:04:20 2008 +1000
> +++ b/arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c Sun Sep 28 18:05:58 2008 +1000
( minor technical request: could you please change your patch scripts to
include the diffstat too? )
Ingo
next prev parent reply other threads:[~2008-10-01 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 23:01 [PATCH] x86: clean up speedctep-centrino and reduce cpumask_t usage Rusty Russell
2008-10-01 6:44 ` Ingo Molnar [this message]
2008-10-02 5:05 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081001064401.GA31855@elte.hu \
--to=mingo@elte.hu \
--cc=davej@redhat.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox