From: Ingo Molnar <mingo@elte.hu>
To: Steven Noonan <steven@uplinklabs.net>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH -tip] drivers/serial/8250.c: 'i' may be used uninitialized
Date: Wed, 1 Oct 2008 10:01:50 +0200 [thread overview]
Message-ID: <20081001080150.GC25832@elte.hu> (raw)
In-Reply-To: <1222847847-7127-3-git-send-email-steven@uplinklabs.net>
( Alan Cc:-ed. Seems like gcc bogosity - so your solution of using
uninitialized_var() is the correct way to annotate this. )
* Steven Noonan <steven@uplinklabs.net> wrote:
> Signed-off-by: Steven Noonan <steven@uplinklabs.net>
> ---
> drivers/serial/8250.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
> index 356c2a2..b51e91e 100644
> --- a/drivers/serial/8250.c
> +++ b/drivers/serial/8250.c
> @@ -1599,7 +1599,7 @@ static int serial_link_irq_chain(struct uart_8250_port *up)
>
> static void serial_unlink_irq_chain(struct uart_8250_port *up)
> {
> - struct irq_info *i;
> + struct irq_info *uninitialized_var(i);
> struct hlist_node *n;
> struct hlist_head *h;
>
> --
> 1.6.0.2
next prev parent reply other threads:[~2008-10-01 8:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 7:57 [PATCH -tip] pcm_native: label out defined but not used Steven Noonan
2008-10-01 7:57 ` [PATCH -tip] sdhci: 'scratch' may be used uninitialized Steven Noonan
2008-10-01 7:57 ` [PATCH -tip] drivers/serial/8250.c: 'i' " Steven Noonan
2008-10-01 8:01 ` Ingo Molnar [this message]
2008-10-01 8:16 ` Steven Noonan
2008-10-01 8:29 ` Ingo Molnar
2008-10-01 8:36 ` Steven Noonan
2008-10-01 8:47 ` [PATCH] " Steven Noonan
2008-10-01 21:36 ` Alan Cox
2008-10-02 9:02 ` Ingo Molnar
2008-10-01 8:48 ` [PATCH -tip] " Ingo Molnar
2008-10-01 10:34 ` Alan Cox
2008-10-01 10:33 ` Alan Cox
2008-10-01 10:57 ` Ingo Molnar
2008-10-01 15:41 ` Alan Cox
2008-10-02 9:00 ` Ingo Molnar
2008-10-01 8:00 ` [PATCH -tip] sdhci: 'scratch' " Ingo Molnar
2008-10-01 8:14 ` Steven Noonan
2008-10-01 8:33 ` Steven Noonan
2008-10-01 8:35 ` Ingo Molnar
2008-10-01 8:50 ` [PATCH] " Steven Noonan
2008-10-04 19:57 ` Pierre Ossman
2008-10-05 14:28 ` Adrian Bunk
2008-10-05 22:53 ` Steven Noonan
2008-10-05 23:16 ` Adrian Bunk
2008-10-05 23:48 ` Steven Noonan
2008-10-06 5:59 ` Adrian Bunk
2008-10-06 6:30 ` Ingo Molnar
2008-10-06 7:27 ` Pierre Ossman
2008-10-06 8:25 ` Ingo Molnar
2008-10-01 7:59 ` [PATCH -tip] pcm_native: label out defined but not used Ingo Molnar
2008-10-01 8:12 ` Steven Noonan
2008-10-01 8:13 ` Takashi Iwai
2008-10-01 8:32 ` Ingo Molnar
2008-10-01 8:56 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081001080150.GC25832@elte.hu \
--to=mingo@elte.hu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=steven@uplinklabs.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox