Re: [PATCH] x86: clean up speedctep-centrino and reduce cpumask_t usage

Ingo Molnar
2008-10-01T06:44:33Z

* Rusty Russell <rusty@rustcorp.com.au> wrote:

> 1) The #ifdef CONFIG_HOTPLUG_CPU seems unnecessary these days.
> 2) The loop can simply skip over offline cpus, rather than creating a tmp mask.
> 3) set_mask is set to either a single cpu or all online cpus in a policy.
> Since it's just used for set_cpus_allowed(), any offline cpus in a policy
> don't matter, so we can just use cpumask_of_cpu() or the policy->cpus.
>
> Note: untested, since I don't have such a system.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

nice cleanup! (Dave Jones Cc:-ed)

maybe it's better to keep this in the cpumask_t series though, to not
complicate logistics?

> diff -r dc205c205c8a arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c
> --- a/arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c Sun Sep 28 18:04:20 2008 +1000
> +++ b/arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c Sun Sep 28 18:05:58 2008 +1000

( minor technical request: could you please change your patch scripts to
include the diffstat too? )

Ingo