Re: [Ocfs2-devel] [PATCH 13/39] ocfs2: Add extended attribute support

Christoph Hellwig
2008-10-02T08:17:13Z

On Wed, Sep 24, 2008 at 03:00:54PM -0700, Mark Fasheh wrote:
> xattr.o \
> + xattr_user.o \
> + xattr_trusted.o

Please don't split this up, it's always been a really stupid idea in
extN. The only difference between secure, trusted and user attrs is
that they go into a different namespace bit (and have different
permission checking, but that's handled in the VFS). I have some
upcoming patches to store a fs private flag in struct xattr_handler
so that even those flags wrappers can go away, and each of the
namespaces will just be five lines of code for the xattr_handler
declaration.

> +static inline struct xattr_handler *ocfs2_xattr_handler(int name_index)
> +{
> + struct xattr_handler *handler = NULL;
> +
> + if (name_index > 0 && name_index < OCFS2_XATTR_MAX)
> + handler = ocfs2_xattr_handler_map[name_index];
> +
> + return handler;
> +}

You seem to need the handler mostly for getting back to the prefix
from the handler. This is a pretty clear indicator that you don't
want to use the xattr_handler splitting but deal with the whole
attr name. Take a look at the btrfs code after my recent xattr changes
on how to handle this more nicely.

> +
> +static inline u32 ocfs2_xattr_name_hash(struct inode *inode,
> + char *prefix,
> + int prefix_len,
> + char *name,
> + int name_len)

And I think there's far too much inlining going on in here..