Re: [Ocfs2-devel] [PATCH 13/39] ocfs2: Add extended attribute support

Christoph Hellwig
2008-10-08T13:17:31Z

On Wed, Oct 08, 2008 at 09:56:41AM +0800, Tiger Yang wrote:
> Mark Fasheh wrote:
> >>>+static inline struct xattr_handler *ocfs2_xattr_handler(int name_index)
> >>>+{
> >>>+ struct xattr_handler *handler = NULL;
> >>>+
> >>>+ if (name_index > 0 && name_index < OCFS2_XATTR_MAX)
> >>>+ handler = ocfs2_xattr_handler_map[name_index];
> >>>+
> >>>+ return handler;
> >>>+}
> >>You seem to need the handler mostly for getting back to the prefix
> >>from the handler. This is a pretty clear indicator that you don't
> >>want to use the xattr_handler splitting but deal with the whole
> >>attr name. Take a look at the btrfs code after my recent xattr changes
> >>on how to handle this more nicely.
> >
> >Tao, Can you look into this?
>
> I have looked the patch for btrfs about this. We are different.
> Btrfs store the whole xattr name including the prefix "user."
> "trusted.", we store index number instead of it.

In which case you shouldn't need to look the handler up anyway. I'll
re-review the code once you post the next version.