Re: [PATCH 11/39] ocfs2: Add extent tree operation for xattr value btrees

Mark Fasheh
2008-10-07T20:19:40Z

On Wed, Oct 01, 2008 at 11:12:01PM -0700, Andrew Morton wrote:
> > On Wed, 24 Sep 2008 15:00:52 -0700 Mark Fasheh <mfasheh@suse.com> wrote:
> > + void *private;
> > };
> >
> > static void ocfs2_dinode_set_last_eb_blk(struct ocfs2_extent_tree *et,
> > @@ -136,9 +137,50 @@ static struct ocfs2_extent_tree_operations ocfs2_dinode_et_ops = {
> > .sanity_check = ocfs2_dinode_sanity_check,
> > };
> >
> > +static void ocfs2_xattr_value_set_last_eb_blk(struct ocfs2_extent_tree *et,
> > + u64 blkno)
> > +{
> > + struct ocfs2_xattr_value_root *xv =
> > + (struct ocfs2_xattr_value_root *)et->private;
>
> unneeded and undesirable cast of void*
>
> > + xv->xr_last_eb_blk = cpu_to_le64(blkno);
> > +}
> > +
> > +static u64 ocfs2_xattr_value_get_last_eb_blk(struct ocfs2_extent_tree *et)
> > +{
> > + struct ocfs2_xattr_value_root *xv =
> > + (struct ocfs2_xattr_value_root *) et->private;
>
> many etceteras.

Thanks, luckily though, it seems these got fixed later in the series :)
--Mark

--
Mark Fasheh