Re: [PATCH 11/39] ocfs2: Add extent tree operation for xattr value btrees

Andrew Morton
2008-10-02T06:13:43Z

> On Wed, 24 Sep 2008 15:00:52 -0700 Mark Fasheh <mfasheh@suse.com> wrote:
> + void *private;
> };
>
> static void ocfs2_dinode_set_last_eb_blk(struct ocfs2_extent_tree *et,
> @@ -136,9 +137,50 @@ static struct ocfs2_extent_tree_operations ocfs2_dinode_et_ops = {
> .sanity_check = ocfs2_dinode_sanity_check,
> };
>
> +static void ocfs2_xattr_value_set_last_eb_blk(struct ocfs2_extent_tree *et,
> + u64 blkno)
> +{
> + struct ocfs2_xattr_value_root *xv =
> + (struct ocfs2_xattr_value_root *)et->private;

unneeded and undesirable cast of void*

> + xv->xr_last_eb_blk = cpu_to_le64(blkno);
> +}
> +
> +static u64 ocfs2_xattr_value_get_last_eb_blk(struct ocfs2_extent_tree *et)
> +{
> + struct ocfs2_xattr_value_root *xv =
> + (struct ocfs2_xattr_value_root *) et->private;

many etceteras.