[PATCH 1/1] block: installing include/linux/blktrace_api.h

[PATCH 1/1] block: installing include/linux/blktrace_api.h

[John Jolly]

From: John Jolly <jjolly@novell.com>

Added line to install include/linux/blktrace_api.h during 'make headers_install'

Signed-off-by: John Jolly <jjolly@novell.com>
CC: Jan Blunck <JBlunck@novell.com>
---
 include/linux/Kbuild |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index b68ec09..f1e5fa1 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -41,6 +41,7 @@ header-y += baycom.h
 header-y += bfs_fs.h
 header-y += blkpg.h
 header-y += bpqether.h
+header-y += blktrace_api.h
 header-y += can.h
 header-y += cdk.h
 header-y += chio.h

Re: [PATCH 1/1] block: installing include/linux/blktrace_api.h

[Andrew Morton]

> On Wed, 24 Sep 2008 08:47:51 -0600 John Jolly <jjolly@novell.com> wrote:
> From: John Jolly <jjolly@novell.com>
> 
> Added line to install include/linux/blktrace_api.h during 'make headers_install'
> 
> Signed-off-by: John Jolly <jjolly@novell.com>
> CC: Jan Blunck <JBlunck@novell.com>
> ---
>  include/linux/Kbuild |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> index b68ec09..f1e5fa1 100644
> --- a/include/linux/Kbuild
> +++ b/include/linux/Kbuild
> @@ -41,6 +41,7 @@ header-y += baycom.h
>  header-y += bfs_fs.h
>  header-y += blkpg.h
>  header-y += bpqether.h
> +header-y += blktrace_api.h
>  header-y += can.h
>  header-y += cdk.h
>  header-y += chio.h

The two basic and almost always necessary parts of a patch changelog are

a) what was changed and

b) why the change was made

Your changelog had no b), hence nobody is likely to apply the patch.

Re: [PATCH 1/1] block: installing include/linux/blktrace_api.h

[Jens Axboe]

On Wed, Oct 01 2008, Andrew Morton wrote:
> > On Wed, 24 Sep 2008 08:47:51 -0600 John Jolly <jjolly@novell.com> wrote:
> > From: John Jolly <jjolly@novell.com>
> > 
> > Added line to install include/linux/blktrace_api.h during 'make headers_install'
> > 
> > Signed-off-by: John Jolly <jjolly@novell.com>
> > CC: Jan Blunck <JBlunck@novell.com>
> > ---
> >  include/linux/Kbuild |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> > index b68ec09..f1e5fa1 100644
> > --- a/include/linux/Kbuild
> > +++ b/include/linux/Kbuild
> > @@ -41,6 +41,7 @@ header-y += baycom.h
> >  header-y += bfs_fs.h
> >  header-y += blkpg.h
> >  header-y += bpqether.h
> > +header-y += blktrace_api.h
> >  header-y += can.h
> >  header-y += cdk.h
> >  header-y += chio.h
> 
> The two basic and almost always necessary parts of a patch changelog are
> 
> a) what was changed and
> 
> b) why the change was made
> 
> Your changelog had no b), hence nobody is likely to apply the patch.

A similar patch is already merged for 2.6.28 as well.

-- 
Jens Axboe

[PATCH 1/1] block: installing include/linux/blktrace_api.h

[John Jolly]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

From: John Jolly <jjolly@novell.com>

Added line to install include/linux/blktrace_api.h during 'make headers_install'

Signed-off-by: John Jolly <jjolly@novell.com>
CC: Jan Blunck <JBlunck@novell.com>
- ---
 include/linux/Kbuild |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index b68ec09..f1e5fa1 100644
- --- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -41,6 +41,7 @@ header-y += baycom.h
 header-y += bfs_fs.h
 header-y += blkpg.h
 header-y += bpqether.h
+header-y += blktrace_api.h
 header-y += can.h
 header-y += cdk.h
 header-y += chio.h
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkjaUeoACgkQdLWlL2z7PiVIogCgtT+z9KQOhY5eza8EoU/O0hKp
XG4AnROtNWlScQA+em7tVxuA9H+22/6Q
=b3Pe
-----END PGP SIGNATURE-----