public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Kim B. Heino" <Kim.Heino@bluegiga.com>
To: "Bosko Radivojevic" <bosko.radivojevic@gmail.com>
Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
	a.zummo@towertech.it
Subject: Re: [PATCH] add support for ST M41T94 SPI RTC (patch rev. 3)
Date: Thu, 2 Oct 2008 20:33:30 +0300	[thread overview]
Message-ID: <20081002203330.295ad5c0@why.bbbs.net> (raw)
In-Reply-To: <d6c8ef150810010551x174fad1mc788e2f6e97b21c5@mail.gmail.com>

> I have AT91SAM9260-based board, kernel is 2.6.26.3.

I'm using my RTC-patch with the same CPU. Custom AT91SAM9260 board,
external RTC because of AT's errata...

> M41T94 is connected on SPI channel 1, chip select 0. I've applied
> Kim's patch and added SPI device in board-sam9260ek.c

> 	{	/* External RTC */
> 		.modalias	= "rtc-m41t94",
> 		.chip_select	= 0,
> 		.max_speed_hz	= 2 * 1000 * 1000,
> 		.bus_num	= 1,
> 	},

I'm using it with ".max_speed_hz = 1 * 1000 * 1000," instead of 2 MHz.
Can you try with slower speed? My patch (rev 3) and this small
ek_spi_devices[] modification should be enough.

I have it on bus = 0, chip_select = 1, so I've also removed dataflash
parts from ek_spi_devices[] (we're using NOR flash). But for you this
is not needed.

I also have a patch to add support for M41T94's watchdog timer. It's
not clean enough to be submitted upstreams yet. If you need it I can
email it to you.

      reply	other threads:[~2008-10-02 17:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-19 11:09 [PATCH] add support for ST M41T94 SPI RTC (patch rev. 3) Kim B. Heino
2008-10-01 12:51 ` Bosko Radivojevic
2008-10-02 17:33   ` Kim B. Heino [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081002203330.295ad5c0@why.bbbs.net \
    --to=kim.heino@bluegiga.com \
    --cc=a.zummo@towertech.it \
    --cc=bosko.radivojevic@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox