From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753322AbYJCMo0 (ORCPT ); Fri, 3 Oct 2008 08:44:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751690AbYJCMoO (ORCPT ); Fri, 3 Oct 2008 08:44:14 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:40510 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751474AbYJCMoM (ORCPT ); Fri, 3 Oct 2008 08:44:12 -0400 Date: Fri, 3 Oct 2008 05:43:55 -0700 From: Andrew Morton To: "Rafael J. Wysocki" Cc: Jeff Garzik , Tejun Heo , ACPI Devel Maling List , linux-ide@vger.kernel.org, Thomas Renninger , Robert Hancock , LKML , Frans Pop , Maciej Rutecki Subject: Re: [PATCH 1/6] Hibernation: Introduce new system state for the last phase of hibernation Message-Id: <20081003054355.e3a3ac79.akpm@linux-foundation.org> In-Reply-To: <200810031327.19293.rjw@sisk.pl> References: <200808290002.55026.rjw@sisk.pl> <200809300010.39000.rjw@sisk.pl> <20081003013557.42ce685d.akpm@linux-foundation.org> <200810031327.19293.rjw@sisk.pl> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 3 Oct 2008 13:27:18 +0200 "Rafael J. Wysocki" wrote: > > Can we just create a new global? > > > > extern bool system_entering_hibernation_or_whatever; > > Yes, we can, but what about: > > extern bool system_entering_hibernation(void); > > that will become a static inline in case of !CONFIG_HIBERNATION, > and using a static variable? Sure, even better.