From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "J.A. Magallón" <jamagallon@ono.com>,
Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] x86: mtrr_cleanup try gran_size to less than 1M
Date: Fri, 3 Oct 2008 09:38:35 +0200 [thread overview]
Message-ID: <20081003073835.GD4950@elte.hu> (raw)
In-Reply-To: <86802c440810021546r6182a0c2id3566c1eb6ab7410@mail.gmail.com>
* Yinghai Lu <yinghai@kernel.org> wrote:
> > boundary handling may have problem...
>
> can you try
>
> diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c
> index ef64128..70beb13 100644
> --- a/arch/x86/kernel/cpu/mtrr/main.c
> +++ b/arch/x86/kernel/cpu/mtrr/main.c
> @@ -1044,7 +1044,7 @@ second_try:
> hole_sizek = range0_sizek - state->range_sizek - second_sizek;
>
> /* hole size should be less than half of range0 size */
> - if (hole_sizek > (range0_sizek >> 1) &&
> + if (hole_sizek >= (range0_sizek >> 1) &&
> range0_sizek >= chunk_sizek) {
applied to tip/x86/mtrr, thanks Yinghai!
Ingo
next prev parent reply other threads:[~2008-10-03 7:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 1:54 [PATCH 1/2] x86: mtrr_cleanup prepare to make gran_size to less 1M Yinghai Lu
2008-09-30 1:54 ` [PATCH 2/2] x86: mtrr_cleanup try gran_size to less than 1M Yinghai Lu
2008-10-02 22:03 ` J.A. Magallón
2008-10-02 22:33 ` Yinghai Lu
2008-10-02 22:52 ` Yinghai Lu
2008-10-02 23:00 ` J.A. Magallón
2008-10-02 23:20 ` Yinghai Lu
2008-10-02 22:58 ` J.A. Magallón
2008-10-02 23:55 ` D. Hugh Redelmeier
2008-10-03 1:27 ` Yinghai Lu
2008-10-02 22:32 ` J.A. Magallón
2008-10-02 22:39 ` Yinghai Lu
2008-10-02 22:46 ` Yinghai Lu
2008-10-03 7:38 ` Ingo Molnar [this message]
2008-10-02 23:20 ` J.A. Magallón
2008-10-02 23:45 ` Yinghai Lu
2008-10-03 7:37 ` Ingo Molnar
2008-10-03 7:38 ` H. Peter Anvin
2008-10-03 7:42 ` Ingo Molnar
2008-10-03 7:44 ` H. Peter Anvin
2008-10-03 14:57 ` D. Hugh Redelmeier
2008-10-03 7:40 ` H. Peter Anvin
2008-10-03 7:44 ` Ingo Molnar
2008-10-03 7:41 ` J.A. Magallón
2008-09-30 4:07 ` [PATCH 1/2] x86: mtrr_cleanup prepare to make gran_size to less 1M H. Peter Anvin
2008-09-30 7:45 ` Ingo Molnar
2008-09-30 8:11 ` Ingo Molnar
2008-09-30 16:06 ` Yinghai Lu
2008-09-30 18:50 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003073835.GD4950@elte.hu \
--to=mingo@elte.hu \
--cc=jamagallon@ono.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox