From: Christoph Hellwig <hch@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Arjan van de Veen <arjan@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Steven Rostedt <rostedt@goodmis.org>,
Jon Masters <jonathan@jonmasters.org>,
Sven Dietrich <sdietrich@suse.de>
Subject: Re: [RFC patch 2/5] genirq: add a quick check handler
Date: Fri, 3 Oct 2008 04:29:27 -0400 [thread overview]
Message-ID: <20081003082927.GA25683@infradead.org> (raw)
In-Reply-To: <20081001223301.900862899@linutronix.de>
On Wed, Oct 01, 2008 at 11:02:18PM -0000, Thomas Gleixner wrote:
> Preparatory patch for threaded interrupt handlers.
>
> Adds a quick check handler which is called before the real handler.
> The quick check handler can decide whether the interrupt was originated
> from the device or not. It can also declare the interrupt as handled
> and subsequently avoid that the real handler is called.
I'd rather leave the handler as a handle which could return
IRQ_NEEDS_HANDLING to get a separate thread_fn called. This seems more
intuitive and means less mess in the fastpath.
Maybe IRQ_NEEDS_HANDLING might better be named IRQ_THREADED os similar,
but that's really getting into nitpicking..
next prev parent reply other threads:[~2008-10-03 8:29 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 23:02 [RFC patch 0/5] genirq: add infrastructure for threaded interrupt handlers Thomas Gleixner
2008-10-01 23:02 ` [RFC patch 1/5] genirq: make irqreturn_t an enum Thomas Gleixner
2008-10-01 23:02 ` [RFC patch 2/5] genirq: add a quick check handler Thomas Gleixner
2008-10-02 0:47 ` Jon Masters
2008-10-02 5:09 ` Steven Rostedt
2008-10-02 10:51 ` Jon Masters
2008-10-02 22:06 ` Greg KH
2008-10-02 4:52 ` Steven Rostedt
2008-10-03 8:29 ` Christoph Hellwig [this message]
2008-10-03 10:37 ` Thomas Gleixner
2008-10-01 23:02 ` [RFC patch 3/5] genirq: add threaded interrupt handler support Thomas Gleixner
2008-10-02 5:01 ` Steven Rostedt
2008-10-01 23:02 ` [RFC patch 4/5] genirq: add a helper to check whether the irq thread should run Thomas Gleixner
2008-10-01 23:02 ` [RFC patch 5/5] genirq: make irq threading robust Thomas Gleixner
2008-10-02 0:52 ` Jon Masters
2008-10-02 5:20 ` Steven Rostedt
2008-10-01 23:23 ` [RFC patch 0/5] genirq: add infrastructure for threaded interrupt handlers Andrew Morton
2008-10-01 23:29 ` Arjan van de Ven
2008-10-01 23:40 ` Andrew Morton
2008-10-01 23:58 ` Thomas Gleixner
2008-10-02 0:40 ` Jon Masters
2008-10-02 22:07 ` Greg KH
2008-10-08 22:18 ` Ingo Oeser
2008-10-02 1:53 ` Daniel Walker
2008-10-02 15:02 ` Steven Rostedt
2008-10-02 15:48 ` Daniel Walker
2008-10-02 18:42 ` Thomas Gleixner
2008-10-02 19:04 ` Daniel Walker
2008-10-02 19:23 ` Steven Rostedt
2008-10-02 19:28 ` Ingo Molnar
2008-10-02 20:09 ` Daniel Walker
2008-10-02 20:14 ` Steven Rostedt
2008-10-02 20:48 ` Daniel Walker
2008-10-02 21:05 ` Steven Rostedt
2008-10-02 21:30 ` Daniel Walker
2008-10-02 22:28 ` Steven Rostedt
2008-10-02 23:24 ` Daniel Walker
2008-10-03 0:26 ` Thomas Gleixner
2008-10-03 14:44 ` Daniel Walker
2008-10-02 14:46 ` Andi Kleen
2008-10-02 21:31 ` Greg KH
2008-10-02 22:33 ` Arjan van de Ven
2008-10-03 3:25 ` Andi Kleen
2008-10-03 3:48 ` Arjan van de Ven
2008-10-03 4:35 ` Andi Kleen
2008-10-03 3:23 ` Andi Kleen
2008-10-21 1:32 ` [RFC patch] genirq threading for ehci, ohci and uhci USB hosts Sven-Thorsten Dietrich
2008-10-21 2:07 ` Jonathan Woithe
2008-10-21 10:29 ` [RFC patch] genirq threading (v2) for ehci, ohci and uhci USB hosts and ohci1394 Sven-Thorsten Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003082927.GA25683@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=benh@kernel.crashing.org \
--cc=jonathan@jonmasters.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=sdietrich@suse.de \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox