From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754088AbYJCSKZ (ORCPT ); Fri, 3 Oct 2008 14:10:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753032AbYJCSKL (ORCPT ); Fri, 3 Oct 2008 14:10:11 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:50928 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752933AbYJCSKK (ORCPT ); Fri, 3 Oct 2008 14:10:10 -0400 Date: Fri, 3 Oct 2008 14:09:31 -0400 From: "John W. Linville" To: Ingo Molnar Cc: Steven Noonan , linux-kernel@vger.kernel.org, ath9k-devel@venema.h4ckr.net, lrodriguez@atheros.com, linux-wireless@vger.kernel.org Subject: Re: ath9k: panic on tip/master Message-ID: <20081003180930.GD3368@tuxdriver.com> References: <20081003100211.GA29841@elte.hu> <20081003153523.GC3368@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081003153523.GC3368@tuxdriver.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 03, 2008 at 11:35:23AM -0400, John W. Linville wrote: > On Fri, Oct 03, 2008 at 12:02:11PM +0200, Ingo Molnar wrote: > > > > * Steven Noonan wrote: > > > > > Hey folks, > > > > > > Just got a panic on tip. According to the stack trace, ath9k is what > > > decided to bomb. > > > > > > http://www.uplinklabs.net/~tycho/linux/ath9k_panic_tip_10.3.2008.jpg > > > > > > Note: Although it says 'sudo modprobe radeon' on the bash prompt above > > > the panic, I never got to hit 'enter' on that command before the panic > > > occurred. > > > > it appears to me that ath9k's eth_rx_input() takes a spinlock that is > > not initialized (or already destroyed by the allocator). > > Seems reasonable... > > > this would be consistent with an IRQ storm hitting some race in the > > ath9k driver init sequence. For example if request_irq() is done before > > all structures that the IRQ handler relies on are properly initialized. > > > > i.e. this has the signature of a genuine ath9k bug. > > Agreed, although I don't see anything specifically relating to > request_irq or the like. > > I think the spin_lock call may actually be in ath_ampdu_input (called > from ath_rx_input), which perhaps is getting called simultaneous > with ath_rx_node_init still running? With no locks in between them, > it seems like this could be the culprit? > > Sorry to not be more immediately helpful, but I'm going to have to > run in a few minutes. Perhaps this insight is helpful for someone > more familiar with the internals of this driver? This is probably a dead-end...I don't think the ath_node_find in ath__rx_indicate will be able to find the ath_node used in ath_ampdu_input unless ath_rx_node_init had already complete. Back to square one... John -- John W. Linville Linux should be at the core linville@tuxdriver.com of your literate lifestyle.