public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Stefan Lippers-Hollmann <s.L-H@gmx.de>
Cc: linux-kernel@vger.kernel.org, tj@kernel.org, jgarzik@redhat.com,
	pchen@nvidia.com, stable@kernel.org
Subject: Re: patch sata_nv-disable-hardreset-for-generic.patch added to 2.6.26-stable tree
Date: Sat, 4 Oct 2008 19:54:01 -0700	[thread overview]
Message-ID: <20081005025401.GA22549@suse.de> (raw)
In-Reply-To: <200810041827.04721.s.L-H@gmx.de>

On Sat, Oct 04, 2008 at 06:27:03PM +0200, Stefan Lippers-Hollmann wrote:
> Hi
> 
> On Donnerstag, 2. Oktober 2008, gregkh@suse.de wrote:
> > 
> > This is a note to let you know that we have just queued up the patch titled
> > 
> >     Subject: sata_nv: disable hardreset for generic
> > 
> > to the 2.6.26-stable tree.  Its filename is
> > 
> >     sata_nv-disable-hardreset-for-generic.patch
> > 
> > A git repo of this tree can be found at 
> >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > 
> > 
> > From 2fd673ecf0378ddeeeb87b3605e50212e0c0ddc6 Mon Sep 17 00:00:00 2001
> > From: Tejun Heo <tj@kernel.org>
> > Date: Fri, 29 Aug 2008 16:13:12 +0200
> > Subject: sata_nv: disable hardreset for generic
> > 
> > From: Tejun Heo <tj@kernel.org>
> > 
> > commit 2fd673ecf0378ddeeeb87b3605e50212e0c0ddc6 upstream
> > 
> > of them being unifying probing, hotplug and EH reset paths uniform.
> > Previously, broken hardreset could go unnoticed as it wasn't used
> > during probing but when something goes wrong or after hotplug the
> > problem will surface and bite hard.
> > 
> > OSDL bug 11195 reports that sata_nv generic flavor falls into this
> > category.  Hardreset itself succeeds but PHY stays offline after
> > hardreset.  I tried longer debounce timing but the result was the
> > same.
> > 
> >   http://bugzilla.kernel.org/show_bug.cgi?id=11195
> > 
> > So, it seems we'll have to drop hardreset from the generic flavor.
> > 
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> > Cc: Peer Chen <pchen@nvidia.com>
> > Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> 
> On 2.6.26.5 + the pending stable queue applied, this patch results in lots 
> of noise in my syslog (full gzipped dmesg with and without this patch 
> attached):

This patch has been removed from the stable queue, so it shouldn't be an
issue anymore, right?

thanks,

greg k-h

  reply	other threads:[~2008-10-05  3:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20081001234424.C72C114543E5@imap.suse.de>
2008-10-04 16:27 ` patch sata_nv-disable-hardreset-for-generic.patch added to 2.6.26-stable tree Stefan Lippers-Hollmann
2008-10-05  2:54   ` Greg KH [this message]
2008-10-05  3:20     ` Tejun Heo
2008-10-05  3:48       ` Greg KH
2008-10-05  4:43         ` Tejun Heo
2008-10-05  5:08           ` Greg KH
2008-10-05 16:00     ` Stefan Lippers-Hollmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081005025401.GA22549@suse.de \
    --to=gregkh@suse.de \
    --cc=jgarzik@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pchen@nvidia.com \
    --cc=s.L-H@gmx.de \
    --cc=stable@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox